Allow edmodule.clone(pset) for PSet to override parameters

[makortel]

PR description:

This PR allows edmodule.clone(pset) to work in the python configuration (previously it could lead to "duplicate parameter" errors if pset had parameters already defined in edmodule). Motivation to allow it is that clone() is (similar to) a constructor call with defaults taken from the cloned-from module. Semantics is that the parameters in pset override those in edmodule. Passing multiple PSets along edmodule.clone(pset1, pset2) is allowed as long as pset1 and pset2 have distinct parameters, similar to EDModule constructors.

Original discussion was in #33354 (comment).

Resolves cms-sw/framework-team#124

PR validation:

Framework unit tests pass.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33673/22574

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/ParameterSet

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[makortel]

@perrotta Here is what we discussed in #33354 (comment) (sorry it took a bit more than "few days in wall clock time")

[Dr15Jones]

As a side note, do you think we should support unnamed dict as inputs as well?

[makortel]

As a side note, do you think we should support unnamed dict as inputs as well?

We kind of do already with edmodule.clone(**dict), although that has a limit of one dict. At this point I would not proceed for direct edmodule.clone(dict), but this is not a strong feeling.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-040d54/14963/summary.html
COMMIT: 880d5d4
CMSSW: CMSSW_12_0_X_2021-05-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33673/14963/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2663174
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2663151
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

@perrotta Here is what we discussed in #33354 (comment) (sorry it took a bit more than "few days in wall clock time")

Thank you @makortel

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1