implements UPT invariant mass triggers in uGT emulator

[cavana]

PR description:

This PR provides a software implementation of the invariant mass correlation condition involving unconstrained pT for displaced muons in the uGT emulator.

No changes in output are expected.

PR validation:

This PR has been validated by the following:
(1) all code changes have been confirmed to compile correctly using
(2) all code changes have been confirmed to execute properly by producing test vectors, which agree with the uGT firmware.
(3) all code changes have been confirmed to execute properly using "runTheMatrix.py -l 11634.0"

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

@cavana, CMSSW_12_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33708/22625

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TGlobal/interface/GlobalScales.h modified in PR(s): L1T bug-fix to the uGT emulator for the unconstrained pT (UPT) invariant mass correlation condition #33350
  • File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc modified in PR(s): L1T bug-fix to the uGT emulator for the unconstrained pT (UPT) invariant mass correlation condition #33350
  • File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.h modified in PR(s): L1T bug-fix to the uGT emulator for the unconstrained pT (UPT) invariant mass correlation condition #33350
  • File L1Trigger/L1TGlobal/src/CorrCondition.cc modified in PR(s): L1T bug-fix to the uGT emulator for the unconstrained pT (UPT) invariant mass correlation condition #33350
  • File L1Trigger/L1TGlobal/src/GlobalScales.cc modified in PR(s): L1T bug-fix to the uGT emulator for the unconstrained pT (UPT) invariant mass correlation condition #33350
  • File L1Trigger/L1TGlobal/src/MuonTemplate.cc modified in PR(s): L1T bug-fix to the uGT emulator for the unconstrained pT (UPT) invariant mass correlation condition #33350

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33708/22625/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33708/22625/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33708/22638

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @cavana (Richard Cavanaugh) for master.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-757382/15056/summary.html
COMMIT: ed475b7
CMSSW: CMSSW_12_0_X_2021-05-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33708/15056/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1260 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 3669
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2644532
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.703 KiB( 36 files compared)
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

[rekovic]

@cavana @cecilecaillol
We need a backport of this in 11_3_X.

[cavana]

@rekovic Will attempt today and report tomorrow.