Add source_only flag for source-only dependencies in calibration

[guitargeek]

PR description:

Add source_only flag for source-only dependencies in calibration. These dependencies were automatically found with this script.

In this PR, the source_only change also made it obvious that some includes were missing in SiPhase2OuterTrackerFakeLorentzAngleESSource.cc (CMSSW did not compile anymore without adding them).

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33728/22663

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CalibTracker/SiPhase2TrackerESProducers
CalibTracker/SiPixelConnectivity
CalibTracker/SiPixelErrorEstimation
CalibTracker/SiPixelQuality
CalibTracker/SiPixelTools
CalibTracker/SiStripChannelGain
CalibTracker/SiStripHitEfficiency
CalibTracker/SiStripLorentzAngle
CalibTracker/SiStripQuality

@malbouis, @yuanchao, @kpedro88, @cmsbuild, @srimanob, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @OzAmram, @alesaggio, @dkotlins, @ferencek, @mmusich, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33728/22666

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #33728 was updated. @malbouis, @yuanchao, @kpedro88, @cmsbuild, @srimanob, @tlampen, @pohsun, @francescobrivio can you please check and sign again.

[tlampen]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd94fa/15093/summary.html
COMMIT: 7b4d903
CMSSW: CMSSW_12_0_X_2021-05-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33728/15093/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2648219
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33728/22679

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #33728 was updated. @malbouis, @yuanchao, @kpedro88, @cmsbuild, @srimanob, @tlampen, @pohsun, @francescobrivio can you please check and sign again.

[srimanob]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd94fa/15119/summary.html
COMMIT: 4759e12
CMSSW: CMSSW_12_0_X_2021-05-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33728/15119/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2648219
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

Technical PR. The discussion happened in #33730

[yuanchao]

+1

• Add source_only flag in calibration. Fixed some missing includes in SiPhase2OuterTrackerFakeLorentzAngleESSource.cc
• builds ok w/o warnings on modified source
• WF matrix tests and unit tests all passed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[silviodonato]

+1