Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of root_numpy in DQM BinByBin tool #33751

Merged
merged 1 commit into from May 18, 2021
Merged

Conversation

jfernan2
Copy link
Contributor

PR description:

Due to unmaintainance of the packet as proposed here:
cms-sw/cmsdist#6896

PR validation:

Tested locally

Due to unmaintainance of the packet as proposed here: 
cms-sw/cmsdist#6896
@jfernan2
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33751/22697

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DQMServices/FileIO

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73ce6/15130/summary.html
COMMIT: 5766b82
CMSSW: CMSSW_12_0_X_2021-05-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33751/15130/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73ce6/15130/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73ce6/15130/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648242
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2648207
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor Author

please test
Errors unrelated to the PR

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73ce6/15136/summary.html
COMMIT: 5766b82
CMSSW: CMSSW_12_0_X_2021-05-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33751/15136/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73ce6/15136/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73ce6/15136/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648242
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2648213
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@davidlange6
Copy link
Contributor

davidlange6 commented May 17, 2021 via email

@jfernan2
Copy link
Contributor Author

Cool - Btw - a unit test of some sort might be useful for this tool. (As to notice when a change breaks it)

Note taken, thanks!

@jfernan2
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e1c83ff into cms-sw:master May 18, 2021
@jfernan2
Copy link
Contributor Author

Cool - Btw - a unit test of some sort might be useful for this tool. (As to notice when a change breaks it)
@davidlange6
Sorry, but I don't see how to define a better Unit Test than the actual Bin by Bin tool being run by cms-bot in:
https://github.com/cms-sw/cms-bot/blob/a1194080497a13d952360c64a2e60643f90108fc/run-pr-comparisons#L152

I have this script which could be run on any DQM root file pair but it would be the same as the cms-bot is doing for every PR test:
https://github.com/cms-sw/cmssw/blob/master/DQMServices/FileIO/scripts/compareFilesFromPR.sh

I do not know if you have in mind any other kind of UnitTest, but the fact that the Bin By Bin tool output is not produced is a real symptom that the script is not working.

Were you thinking of a short message in case of failing in the Comparison Summary produced by the bot instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants