New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of root_numpy in DQM BinByBin tool #33751
Conversation
Due to unmaintainance of the packet as proposed here: cms-sw/cmsdist#6896
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33751/22697
|
A new Pull Request was created by @jfernan2 for master. It involves the following packages: DQMServices/FileIO @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test test_PixelBaryCentreTool had ERRORS Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73ce6/15136/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Cool - Btw - a unit test of some sort might be useful for this tool. (As to notice when a change breaks it)
… On May 17, 2021, at 7:25 PM, cmsbuild ***@***.***> wrote:
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73ce6/15136/summary.html
COMMIT: 5766b82
CMSSW: CMSSW_12_0_X_2021-05-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33751/15136/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
• #33704 @bsunanda: Run3-gex74N Bug fix for the material budget code and add a macro for getting the plots
• #33739 @Dr15Jones: Added link needed for debug build of SimTransport/PPSProtonTransport
• #33711 @silviodonato: Remove hardcoded number (255) about the L1 prefiring
• #33731 @slava77: speedup of trackValidatorJetCore and TrackAssociatorByChi2
• #33652 @marksan87: Migrate PF modules to esConsumes
• #33680 @fabiocos: MTD reconstruction: code cleaning for old comments (issue #24452)
• #33740 @Dr15Jones: Fix debug build of L1Trigger/DTTriggerPhase2
• #33741 @Dr15Jones: Avoid type punning in L1Trigger/CSCTrackFinder
• #33747 @Dr15Jones: Fix import in Phase1L1TJetProducer_cfi for python 3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73ce6/15136/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73ce6/15136/git-merge-result
Comparison Summary
Summary:
• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2648213
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Note taken, thanks! |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
I have this script which could be run on any DQM root file pair but it would be the same as the cms-bot is doing for every PR test: I do not know if you have in mind any other kind of UnitTest, but the fact that the Bin By Bin tool output is not produced is a real symptom that the script is not working. Were you thinking of a short message in case of failing in the Comparison Summary produced by the bot instead? |
PR description:
Due to unmaintainance of the packet as proposed here:
cms-sw/cmsdist#6896
PR validation:
Tested locally