New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GEM Offline DQM #33773
Update GEM Offline DQM #33773
Conversation
* 'bookEfficiencyEtaPartition' is renamed 'bookEfficiencyDetector' and the efficiency plot is created for each GEM layer, not station. * New 'bookEfficiencyEtaPartition' creates the 1D efficiency vs ieta plots * Change the default of 'useSkipLayer' to true for the both beam and cosmics scenarios. * Reduce the number of bins of the phi efficiency plots. * `buildGEMLayers` make two disks, the odd chambers and the even chambers of GE11. * Add TransientTrackBuilder_cfi in `GEMEfficiencyAnalyzer` cfi files for use standalone.
…m build COMPILER='llvm compile'`.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33773/22737
|
A new Pull Request was created by @seungjin-yang for master. It involves the following packages: DQMOffline/Muon @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33773/22738
|
Pull request #33773 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6ef7e/15181/summary.html CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6ef7e/15181/llvm-analysis/cmsclangtidy.txt for details. Comparison SummarySummary:
|
+1 |
Backport to 11_3_X needed in view of MWGR4 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
bookEfficiencyEtaPartition
is renamedbookEfficiencyDetector
and the efficiency plot is created for each GEM layer, not station.bookEfficiencyEtaPartition
creates the 1D efficiency vs ieta plotsuseSkipLayer
to true for the both beam and cosmics scenarios.buildGEMLayers
make two disks, the odd chambers and the even chambers of GE11.TransientTrackBuilder_cfi
inGEMEfficiencyAnalyzer
cfi files for use standalone.PR validation:
This PR is tested using
/RelValZMM_14/CMSSW_12_0_0_pre1-113X_mcRun3_2021_realistic_v10-v1/GEN-SIM-RECO
(i.e. 11650 (ZMM_14))PR validation results can be found at the local offline DQM GUI server. Please look at the GEM workspace.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is NOT a backport.
This update will be backported to CMSSW_11_3_X through other PR for MWGR#4.
@jshlee, @szaleski