Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GEM Offline DQM #33773

Conversation

seungjin-yang
Copy link
Contributor

PR description:

  • bookEfficiencyEtaPartition is renamed bookEfficiencyDetector and the efficiency plot is created for each GEM layer, not station.
  • New bookEfficiencyEtaPartition creates the 1D efficiency vs ieta plots
  • Change the default of useSkipLayer to true for the both beam and cosmics scenarios.
  • Reduce the number of bins of the phi efficiency plots.
  • buildGEMLayers make two disks, the odd chambers and the even chambers of GE11.
  • Add TransientTrackBuilder_cfi in GEMEfficiencyAnalyzer cfi files for use standalone.

PR validation:

This PR is tested using /RelValZMM_14/CMSSW_12_0_0_pre1-113X_mcRun3_2021_realistic_v10-v1/GEN-SIM-RECO (i.e. 11650 (ZMM_14))

PR validation results can be found at the local offline DQM GUI server. Please look at the GEM workspace.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is NOT a backport.

This update will be backported to CMSSW_11_3_X through other PR for MWGR#4.

@jshlee, @szaleski

* 'bookEfficiencyEtaPartition' is renamed 'bookEfficiencyDetector' and the efficiency plot is created for each GEM layer, not station.
* New 'bookEfficiencyEtaPartition' creates the 1D efficiency vs ieta plots
* Change the default of 'useSkipLayer' to true for the both beam and cosmics scenarios.
* Reduce the number of bins of the phi efficiency plots.
* `buildGEMLayers` make two disks, the odd chambers and the even chambers of GE11.
* Add TransientTrackBuilder_cfi in `GEMEfficiencyAnalyzer` cfi files for use standalone.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33773/22737

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @seungjin-yang for master.

It involves the following packages:

DQMOffline/Muon

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @barvic, @bellan, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @ptcox, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33773/22738

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33773 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6ef7e/15181/summary.html
COMMIT: c683704
CMSSW: CMSSW_12_0_X_2021-05-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33773/15181/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6ef7e/15181/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648086
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 2648032
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 18.96 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -0.508 KiB GEM/Efficiency
  • DQMHistoSizes: changed ( 23234.0,... ): -1.016 KiB GEM/Efficiency
  • DQMHistoSizes: changed ( 34634.0,... ): 11.258 KiB GEM/Efficiency
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@jfernan2
Copy link
Contributor

Backport to 11_3_X needed in view of MWGR4

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 19, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants