Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Modification to PythiaFilterMotherSister #33815

Merged

Conversation

mgratti
Copy link
Contributor

@mgratti mgratti commented May 21, 2021

This PR is a backport of #33806

Needed for an MC production with B-parking conditions.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mgratti (Maria Giulia Ratti) for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented May 22, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763f2/15251/summary.html
COMMIT: 65b32df
CMSSW: CMSSW_10_2_X_2021-05-16-0000/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33815/15251/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007354
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@mgratti
Copy link
Contributor Author

mgratti commented May 25, 2021

Hi, please, hold on this PR, because the original PR (#33806) is not yet merged.
Sorry for the confusion.

@SiewYan
Copy link
Contributor

SiewYan commented May 25, 2021

Hello, yes and thanks for the comment. I am also seeing the Duplicate Dictionaries error [*]. I don't think this is relevant to the unmerged PR, but its good to understand why too.

[*] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763f2/15251/summary.html

@mgratti
Copy link
Contributor Author

mgratti commented May 25, 2021

Hi, I went through the logs where errors were signalled [1], but there is no sign that something went wrong there

[1] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763f2/15251/dupDict/

@qliphy
Copy link
Contributor

qliphy commented May 25, 2021

The Duplicate Dictionaries error is not related to this PR, and has been also mentioned in below:
#33752 (comment)

@silviodonato
Copy link
Contributor

@mgratti please consider to have a backport also to 10_6_X for a possible future b-parking ultralegacy

@agrohsje
Copy link

Just to say: the original one is still to be updated: #33806.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2021

Pull request #33815 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

@mgratti
Copy link
Contributor Author

mgratti commented Jun 1, 2021

the PR was updated to follow the modifications done in the master, see #33806

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

Pull request #33815 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

@agrohsje
Copy link

agrohsje commented Jun 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763f2/15756/summary.html
COMMIT: 2d3472c
CMSSW: CMSSW_10_2_X_2021-06-06-0000/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33815/15756/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1045 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 2085
  • DQMHistoTests: Total nulls: 51
  • DQMHistoTests: Total successes: 3005220
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 56.705 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 10.938 KiB Info/EventInfo
  • DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 140.53 ): 0.064 KiB SiStrip/MechanicalView
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@agrohsje
Copy link

agrohsje commented Jun 8, 2021

@silviodonato @qliphy i am puzzled that there are 2084 failures in workflow: 140.53 https://cmssdt.cern.ch/lxr/source/Configuration/PyReleaseValidation/python/relval_standard.py?v=CMSSW_12_0_X_2021-06-01-2300 . shouldn't be related to this pr.

@qliphy
Copy link
Contributor

qliphy commented Jun 8, 2021

@agrohsje It is a known due to the fact "140.53 have different files in step1_dasquery.log than the ones found in the baseline" You can ignore these differences from 140.53.

@agrohsje
Copy link

agrohsje commented Jun 8, 2021

Thanks @qliphy for clarifying.

@agrohsje
Copy link

agrohsje commented Jun 8, 2021

+generators

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 8, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants