New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] Modification to PythiaFilterMotherSister #33815
[backport] Modification to PythiaFilterMotherSister #33815
Conversation
A new Pull Request was created by @mgratti (Maria Giulia Ratti) for CMSSW_10_2_X. It involves the following packages: GeneratorInterface/GenFilters @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763f2/15251/summary.html Comparison SummarySummary:
|
Hi, please, hold on this PR, because the original PR (#33806) is not yet merged. |
Hello, yes and thanks for the comment. I am also seeing the Duplicate Dictionaries error [*]. I don't think this is relevant to the unmerged PR, but its good to understand why too. [*] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763f2/15251/summary.html |
Hi, I went through the logs where errors were signalled [1], but there is no sign that something went wrong there [1] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763f2/15251/dupDict/ |
The Duplicate Dictionaries error is not related to this PR, and has been also mentioned in below: |
@mgratti please consider to have a backport also to 10_6_X for a possible future b-parking ultralegacy |
Just to say: the original one is still to be updated: #33806. |
…e leptons and tracks
Pull request #33815 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again. |
the PR was updated to follow the modifications done in the master, see #33806 |
Pull request #33815 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5763f2/15756/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
@silviodonato @qliphy i am puzzled that there are 2084 failures in workflow: 140.53 https://cmssdt.cern.ch/lxr/source/Configuration/PyReleaseValidation/python/relval_standard.py?v=CMSSW_12_0_X_2021-06-01-2300 . shouldn't be related to this pr. |
@agrohsje It is a known due to the fact "140.53 have different files in step1_dasquery.log than the ones found in the baseline" You can ignore these differences from 140.53. |
Thanks @qliphy for clarifying. |
+generators |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR is a backport of #33806
Needed for an MC production with B-parking conditions.