New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update recommended list of MET filters #33818
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33818/22815
|
A new Pull Request was created by @lathomas for master. It involves the following packages: PhysicsTools/NanoAOD @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
it looks like the failures were related to execution with this PR code.
please fix. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33818/22995
|
would |
Ah yes there's an existing example for customizing the filters for FastSim actually so that should work ! Thanks. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33818/23843
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bdf32/16665/summary.html Comparison SummarySummary:
|
|
Yes this is the current recommendation. It turns out the MC and data recommendation are now identical so no dedicated modifier is needed . |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The PR update the list of MET filters run in the global boolean Flag_METFilters.
The list was discussed here:
https://indico.cern.ch/event/1042496/#27-update-on-ul-met-filters
and corresponds to the list in this twiki:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/MissingETOptionalFiltersRun2#Analysis_Recommendations_for_ana
PR validation:
runTheMatrix.py -l limited -i all --ibeos
is run successfully