Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recommended list of MET filters #33818

Merged
merged 4 commits into from Jul 12, 2021

Conversation

lathomas
Copy link
Contributor

@lathomas lathomas commented May 22, 2021

PR description:

The PR update the list of MET filters run in the global boolean Flag_METFilters.
The list was discussed here:
https://indico.cern.ch/event/1042496/#27-update-on-ul-met-filters
and corresponds to the list in this twiki:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/MissingETOptionalFiltersRun2#Analysis_Recommendations_for_ana

PR validation:

runTheMatrix.py -l limited -i all --ibeos
is run successfully

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33818/22815

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lathomas for master.

It involves the following packages:

PhysicsTools/NanoAOD
RecoMET/METFilters

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @swertz, @ahinzmann, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @gpetruc, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented May 24, 2021

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bdf32/15266/summary.html
COMMIT: 3f89dac
CMSSW: CMSSW_12_0_X_2021-05-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33818/15266/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 136.7722136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log
  • 1329.11329.1_ZEE_13_80XNanoAODINPUT+ZEE_13_80XNanoAODINPUT+NANOEDMMC2016_80X+HARVESTNANOAODMC2016_80X/step2_ZEE_13_80XNanoAODINPUT+ZEE_13_80XNanoAODINPUT+NANOEDMMC2016_80X+HARVESTNANOAODMC2016_80X.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 17 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 2650454
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.172 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 312.0 ): 0.008 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: found differences in 26 / 36 workflows

@slava77
Copy link
Contributor

slava77 commented May 31, 2021

it looks like the failures were related to execution with this PR code.
eg. in 136.7722

An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 283877 lumi: 11 event: 17578209 stream: 0
   [1] Running path 'nanoAOD_step'
   [2] Calling method for module GlobalVariablesTableProducer/'extraFlagsTable'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: bool
Looking for module label: BadChargedCandidateTagger
Looking for productInstanceName: 

please fix.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33818/22995

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33818 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jul 2, 2021

Thanks. This doesn't differentiate between data and MC however. Do you have an example for that? Or do I misread these lines?

would miniAOD_customizeData, miniAOD_customizeMC, and miniAOD_customizeAllMCFastSim work for you?

@lathomas
Copy link
Contributor Author

lathomas commented Jul 2, 2021

Ah yes there's an existing example for customizing the filters for FastSim actually so that should work ! Thanks.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33818/23843

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

Pull request #33818 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Jul 9, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bdf32/16665/summary.html
COMMIT: 45fba54
CMSSW: CMSSW_12_0_X_2021-07-09-0800/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33818/16665/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786260
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 2786230
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.176 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: found differences in 27 / 37 workflows

@perrotta
Copy link
Contributor

@lathomas

@lathomas
Copy link
Contributor Author

Yes this is the current recommendation. It turns out the MC and data recommendation are now identical so no dedicated modifier is needed .

@perrotta
Copy link
Contributor

+reconstruction

  • List of MET filters updated with the latest recommendations from the JET/MET group
    • List is different for 2016 and 2017/18 data and MC: finally no specialization for MC or FastSim is foreseen
  • Jenkins tests pass and only show differences in the events passing one single path of the TriggerResults, the one triggered by the bool resulting from the union of those recommended filters

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants