From 71832780caad2fce2ca6c37e066189adec23e27f Mon Sep 17 00:00:00 2001 From: Laurent Date: Sat, 22 May 2021 16:55:47 +0200 Subject: [PATCH 1/4] PhysicsTools/NanoAOD/python/extraflags_cff.py --- RecoMET/METFilters/python/metFilters_cff.py | 42 +++++++-------------- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/RecoMET/METFilters/python/metFilters_cff.py b/RecoMET/METFilters/python/metFilters_cff.py index d48fb6ef09d0d..f147d8ede602e 100644 --- a/RecoMET/METFilters/python/metFilters_cff.py +++ b/RecoMET/METFilters/python/metFilters_cff.py @@ -95,39 +95,23 @@ from RecoMET.METFilters.hfNoisyHitsFilter_cfi import * metFilters = cms.Sequence( - HBHENoiseFilterResultProducer * - HBHENoiseFilter * - primaryVertexFilter* -# HBHENoiseIsoFilter* -# HcalStripHaloFilter * - CSCTightHaloFilter * -# hcalLaserEventFilter * - #Various proposals for updated halo filters. - ##2015 proposals: - #CSCTightHaloTrkMuUnvetoFilter * - #CSCTightHalo2015Filter * - ##2016 proposals - #globalTightHalo2016Filter* - #globalSuperTightHalo2016Filter* - EcalDeadCellTriggerPrimitiveFilter* - ecalBadCalibFilter* -# *goodVertices * trackingFailureFilter * - eeBadScFilter* -# ecalLaserCorrFilter * -# trkPOGFilters - chargedHadronTrackResolutionFilter * - BadChargedCandidateFilter* - BadPFMuonFilter * - BadPFMuonDzFilter * - hfNoisyHitsFilter * - BadChargedCandidateSummer16Filter* - BadPFMuonSummer16Filter * - muonBadTrackFilter + goodVertices * + globalSuperTightHalo2016Filter * + HBHENoiseFilterResultProducer * + HBHENoiseFilter * + HBHENoiseIsoFilter * + EcalDeadCellTriggerPrimitiveFilter * + BadPFMuonFilter * + BadPFMuonDzFilter * + EcalDeadCellTriggerPrimitiveFilter * + ecalBadCalibFilter * + eeBadScFilter + ) from Configuration.Eras.Modifier_phase2_hgcal_cff import phase2_hgcal phase2_hgcal.toReplaceWith(metFilters, metFilters.copyAndExclude([ - HBHENoiseFilterResultProducer, HBHENoiseFilter, # No hcalnoise for hgcal + HBHENoiseFilterResultProducer, HBHENoiseFilter, HBHENoiseIsoFilter, # No hcalnoise for hgcal eeBadScFilter # No EE ])) From 3f89dac9706a2c0addc5d96cf101cfd3c88abd5a Mon Sep 17 00:00:00 2001 From: Laurent Date: Sat, 22 May 2021 16:59:27 +0200 Subject: [PATCH 2/4] Update recommended list of MET filters, disable recomputation on MINIAOD --- PhysicsTools/NanoAOD/python/extraflags_cff.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PhysicsTools/NanoAOD/python/extraflags_cff.py b/PhysicsTools/NanoAOD/python/extraflags_cff.py index 6d782122f8bec..877e8502df0b0 100644 --- a/PhysicsTools/NanoAOD/python/extraflags_cff.py +++ b/PhysicsTools/NanoAOD/python/extraflags_cff.py @@ -37,7 +37,9 @@ ) ) -extraFlagsProducers = cms.Sequence(badGlobalMuonTagger + cloneGlobalMuonTagger + BadPFMuonTagger + BadChargedCandidateTagger) +extraFlagsProducers = cms.Sequence() +#The following line shows an example how to recompute MET filter decisions on top of MINIAOD in case the filter has been updated/is missing. This should not be the default in general. +#extraFlagsProducers = cms.Sequence(badGlobalMuonTagger + cloneGlobalMuonTagger + BadPFMuonTagger + BadChargedCandidateTagger) from RecoMET.METFilters.ecalBadCalibFilter_cfi import * ecalBadCalibFilterNanoTagger = ecalBadCalibFilter.clone( From 0af91ef9a1c37c6e5ef416a727e3b23c413f5a9f Mon Sep 17 00:00:00 2001 From: Laurent Date: Mon, 31 May 2021 20:56:30 +0200 Subject: [PATCH 3/4] reverting back to original extraflags_cff.py --- PhysicsTools/NanoAOD/python/extraflags_cff.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/PhysicsTools/NanoAOD/python/extraflags_cff.py b/PhysicsTools/NanoAOD/python/extraflags_cff.py index 877e8502df0b0..6d782122f8bec 100644 --- a/PhysicsTools/NanoAOD/python/extraflags_cff.py +++ b/PhysicsTools/NanoAOD/python/extraflags_cff.py @@ -37,9 +37,7 @@ ) ) -extraFlagsProducers = cms.Sequence() -#The following line shows an example how to recompute MET filter decisions on top of MINIAOD in case the filter has been updated/is missing. This should not be the default in general. -#extraFlagsProducers = cms.Sequence(badGlobalMuonTagger + cloneGlobalMuonTagger + BadPFMuonTagger + BadChargedCandidateTagger) +extraFlagsProducers = cms.Sequence(badGlobalMuonTagger + cloneGlobalMuonTagger + BadPFMuonTagger + BadChargedCandidateTagger) from RecoMET.METFilters.ecalBadCalibFilter_cfi import * ecalBadCalibFilterNanoTagger = ecalBadCalibFilter.clone( From 45fba54b70cc152d4fcc4affa6146a329b9df4d2 Mon Sep 17 00:00:00 2001 From: Laurent Date: Fri, 9 Jul 2021 18:53:14 +0200 Subject: [PATCH 4/4] Update MET filter recommendation --- RecoMET/METFilters/python/metFilters_cff.py | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/RecoMET/METFilters/python/metFilters_cff.py b/RecoMET/METFilters/python/metFilters_cff.py index f147d8ede602e..03a992c9b16a8 100644 --- a/RecoMET/METFilters/python/metFilters_cff.py +++ b/RecoMET/METFilters/python/metFilters_cff.py @@ -100,13 +100,12 @@ HBHENoiseFilterResultProducer * HBHENoiseFilter * HBHENoiseIsoFilter * - EcalDeadCellTriggerPrimitiveFilter * + EcalDeadCellTriggerPrimitiveFilter * BadPFMuonFilter * BadPFMuonDzFilter * - EcalDeadCellTriggerPrimitiveFilter * - ecalBadCalibFilter * - eeBadScFilter - + hfNoisyHitsFilter * + eeBadScFilter * + ecalBadCalibFilter ) from Configuration.Eras.Modifier_phase2_hgcal_cff import phase2_hgcal @@ -115,3 +114,9 @@ eeBadScFilter # No EE ])) + +from Configuration.Eras.Modifier_run2_jme_2016_cff import run2_jme_2016 +run2_jme_2016.toReplaceWith(metFilters, metFilters.copyAndExclude([ + ecalBadCalibFilter, hfNoisyHitsFilter +])) +