Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD, JMENanoAOD] Backport of #33824 (Remove jercVars variables, update puId config) to 11_2_X #33834

Merged

Conversation

nurfikri89
Copy link
Contributor

Backport from #33824

PR description:

This PR aims to

  • Remove certain jercVars variables from the main NanoAOD but still keep them in the JMENano.
  • Update configurations for pileup Id in JMENano.

With this PR, the event size for the main Nano is reduced from 2.90 kb/event to 2.86 kb/event. The comparison was made using 5K events from a TTJets RunIISummer20UL17MiniAODv2 sample. No event size changes for JMENano.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Original PR is #33824

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_11_2_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test
(we need backport only on 10_6)

@nurfikri89
Copy link
Contributor Author

@mariadalfonso ok. Should I close this PR?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b868d/15298/summary.html
COMMIT: efffe59
CMSSW: CMSSW_11_2_X_2021-05-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33834/15298/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 106 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2537235
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2537200
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.969 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 1325.81 ): -1.857 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 136.8523 ): -1.116 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor

+xpog

backport inline with master
(not strictly needed backport in 11_2 but can be useful if jmenano will be produced in 11-2 in the future)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 26, 2021

+1

@cmsbuild cmsbuild merged commit 0d904de into cms-sw:CMSSW_11_2_X May 26, 2021
@nurfikri89 nurfikri89 deleted the portFrom120XTo112X_nano_jercVars_PuId branch July 15, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants