More BuildFiles cleaning

[guitargeek]

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #33445).

This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added for 12_0_0_pre2.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33858/22885

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoHGCal/TICL/plugins/BuildFile.xml modified in PR(s): [DD4hep] start on geometry XML payload producer #33548

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

Calibration/TkAlCaRecoProducers
L1Trigger/CSCTriggerPrimitives
L1Trigger/L1TTrackMatch
L1Trigger/Phase2L1Taus
L1Trigger/VertexFinder
RecoHGCal/TICL
RecoLocalTracker/SiStripClusterizer
RecoParticleFlow/PFClusterTools
RecoTracker/FinalTrackSelectors
SimDataFormats/Associations
SimTracker/SiStripDigitizer
Validation/HGCalValidation
Validation/RecoParticleFlow

@perrotta, @malbouis, @civanch, @yuanchao, @ahmad3213, @kmaeshima, @tlampen, @andrius-k, @kpedro88, @ErnestaP, @cmsbuild, @rekovic, @srimanob, @jfernan2, @mdhildreth, @slava77, @jpata, @pohsun, @rvenditti, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @yduhm, @robervalwalsh, @Martin-Grunewald, @bsunanda, @pfs, @lgray, @threus, @mmusich, @seemasharmafnal, @mmarionncern, @sethzenz, @makortel, @JanFSchulte, @dgulhan, @valuev, @apsallid, @prolay, @dildick, @vandreev11, @pieterdavid, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @ptcox, @tocheng, @hatakeyamak, @alesaggio, @ebrondol, @mtosi, @fabiocos, @clelange, @gbenelli, @sobhatta, @lecriste, @cbernet, @gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd5f83/15340/summary.html
COMMIT: d4fef25
CMSSW: CMSSW_12_0_X_2021-05-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33858/15340/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1268 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 3675
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2646770
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.703 KiB( 36 files compared)
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• Technical
• Jenkins tests pass

[cecilecaillol]

+l1

[jfernan2]

+1

[srimanob]

+Upgrade

@guitargeek
Do we have a plan to implement a tool that will be triggered during PR test? This will reduce this fix PRs in the future.

[guitargeek]

I don't know, you have to ask that the core group. There is also this discussion here about avoiding BuildFiles altogether:
cms-sw/cmsdist#5992

I agree that it would be nice to have this as part of the PR checks.

[yuanchao]

Got the following error on "duplicate dictionaries":
'''Searching for 'classes_def.xml' in '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-26-1100/src'.

./DataFormats/L1Trigger/src/classes_def.xml
Vertex : l1t::Vertex
Vertex : vector< l1t::Vertex >'''

@guitargeek Could you confirm if this is ok? For the rest of tests, no problem is found.

[guitargeek]

That's okay. You can see the error also in other PRs, so it's not related to the changes I propose here. See for example
#33859

[perrotta]

That's okay. You can see the error also in other PRs, so it's not related to the changes I propose here. See for example
#33859

... and a fix is already merged with #33850, it will enter the next IB

[yuanchao]

+1

[guitargeek]

Hi @civanch, is this PR okay for you? Thanks!

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1