adding a specified HFNose_noise_fC parameter set to avoid overwriting…

[pfs]

… of default parameters for HGCal

PR description:

The HFnose and HGCal Si section share analogous digitization code and configuration files.
In both cases the parameters used to model the realistic detector/noise are read from a refToPSet which has been kept common up to this PR.
In recent releases, when the aging of HFNose was introduced, we have overlooked the fact that in the configuration it ends up overwriting the a crucial parameter which sets the dose/fluence map to be used. This parameter is firstly set to the default HGCAL but immediately changed afterwards to the HFnose one, which is is not suitable for HGCAL.
This happens when the following customisation is made

--customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_3000

As a result the HGCAL part of the simulation turns out to be incorrect in workflows where aging has been enabled.
This PR fixes this by introducing a separate PSet for HFNose. Initially it is made as a clone of the HGCAL_noise_fC PSet and when the customise is called it sets the proper values for HFnose, namely the doseMap.

PR validation:

We have checked with

runTheMatrix.py -w upgrade -l 23234.103

that the final configuration is correct and that the events obtained after the DIGI step are consistent with the ones we had in 11_2_X. For illustration two plots comparing the before and after on a handful of events.

@ttrk
@mariadalfonso can you check the proposed changes are ok from the HFnose point of view
@franzoni this is probably one of the last PRs you're required to follow in CMS?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33861/22892

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @pfs (Pedro Silva) for master.

It involves the following packages:

SimCalorimetry/HGCalSimProducers
SimGeneral/MixingModule

@mdhildreth, @cmsbuild, @civanch, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @makortel, @rovere, @lgray, @cseez, @apsallid, @hatakeyamak, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a012d9/15382/summary.html
COMMIT: 84fa5fb
CMSSW: CMSSW_12_0_X_2021-05-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33861/15382/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2650463
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1