[Backport] Making miniAOD low pt tracks threshold tunable for 10_6_X (#33777)

[AdrianoDee]

PR description:

This is a backport to 10_6_X of #33777

PR validation:

All the tests running

Further references

BPH Jamboree December 2020 here

xPOG Meeting February 2021 here

Further reference here

For a complete documentation, trk4bph meetings: 1, 2, 3 , 4, 5, 6

[cmsbuild]

A new Pull Request was created by @AdrianoDee for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Making miniAOD low pt tracks threshold tunable #33777

[AdrianoDee]

N.B. most of the changes to PhysicsTools/PatAlgos/plugins/PATPackedCandidateProducer.cc comes from code-format checks.

[perrotta]

backport of #33777

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b6a4a/15379/summary.html
COMMIT: c8cb07a
CMSSW: CMSSW_10_6_X_2021-05-27-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33877/15379/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1380 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215552
• DQMHistoTests: Total failures: 1249
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3213969
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[slava77]

Reco comparison results: 1380 differences found in the comparisons

106X is a production release and this PR is changing outputs of the standard workflows.
This is not allowed by change policy.

• You can change the PR to have no change by default configuration e.g. only with run2_miniAOD_devel, or/and (bParking & run2_miniAOD_UL)

[AdrianoDee]

@slava77 thanks. Would something like this work?

for lostTracks_cfi.py

from Configuration.Eras.Modifier_bParking_cff import bParking
bParking.toModify(lostTracks, fillLostInnerHits = True)
(bParking & run2_miniAOD_UL).toModify(lostTracks, minPtToStoreLowQualityProps = 0.0)

from Configuration.Eras.Modifier_run2_miniAOD_devel_cff.py import run2_miniAOD_devel
run2_miniAOD_devel.toModify(lostTracks, minPtToStoreLowQualityProps = 0.0)

and for packedPFCanidates_cfi.py

from Configuration.Eras.Modifier_run2_miniAOD_devel_cff.py import run2_miniAOD_devel
run2_miniAOD_devel.toModify(packedPFCandidates, minPtForLowQualityTrackProperties = 0.0)

from Configuration.Eras.Modifier_bParking_cff.py import bParking
(bParking & run2_miniAOD_UL).toModify(packedPFCandidates, minPtForLowQualityTrackProperties = 0.0)

[slava77]

@slava77 thanks. Would something like this work?

I'd use something shorter:

(bParking | run2_miniAOD_devel).toModify(

[cmsbuild]

Pull request #33877 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b6a4a/15420/summary.html
COMMIT: dfbfb78
CMSSW: CMSSW_10_6_X_2021-05-29-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33877/15420/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215543
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215207
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #33877 dfbfb78

• code changes are in line with the PR description and the follow up review:
  • the backport is correct; the extra code formatting in PATPackedCandidateProducer.cc and packedPFCandidates_cfi.py is acceptable
  • the changes are enabled only for bParking | run2_miniAOD_devel to satisfy the no-change policy
• jenkins tests pass and comparisons with the baseline show no (relevant) differences
  • this signoff relies on changes in physics observed in the 12X PR Making miniAOD low pt tracks threshold tunable #33777 (see the PR description there and pre-signoff plots from the bot Making miniAOD low pt tracks threshold tunable #33777 (comment))

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1