New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GeneratorInterface null termination issues #33932
Fix GeneratorInterface null termination issues #33932
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33932/23008
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: GeneratorInterface/AMPTInterface @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e476b8/15581/summary.html Comparison SummarySummary:
|
+generators |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
std::string::data()
is not guaranteed to be nul terminated, sostrlen(string.data())
is unsafe. This corrects the problem by usingstd::string::c_str()
andstd::string::length()
. Completes a partial fix in #33687, hopefully resolves #33452.PR validation:
Trivial technical fix, compiles.