Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not print SiStrip O2O passwords in dbParams_ #33953

Merged
merged 1 commit into from Jun 3, 2021
Merged

do not print SiStrip O2O passwords in dbParams_ #33953

merged 1 commit into from Jun 3, 2021

Conversation

quinnanm
Copy link
Contributor

@quinnanm quinnanm commented Jun 2, 2021

PR description:

Addition to "do not print SiStrip O2O passwords in clear" #33900

prevents SiStripConfigDb.cc (https://github.com/cms-sw/cmssw/blob/CMSSW_12_0_DEVEL_X/OnlineDB/SiStripConfigDb/src/SiStripConfigDb.cc#L124) from printing password

PR validation:

It compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #33947

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

A new Pull Request was created by @quinnanm (Melissa Quinnan) for CMSSW_10_2_X.

It involves the following packages:

OnlineDB/SiStripConfigDb

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@erikbutz, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jun 2, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51c950/15560/summary.html
COMMIT: 2c12675
CMSSW: CMSSW_10_2_X_2021-06-01-1100/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33953/15560/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007355
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@ggovi
Copy link
Contributor

ggovi commented Jun 2, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 3, 2021

+1

@cmsbuild cmsbuild merged commit c02fdbb into cms-sw:CMSSW_10_2_X Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants