Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate module config in RecoTracker{IterativeTracking} to use default cfipython v2 #34007

Merged
merged 1 commit into from Jun 8, 2021

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Jun 8, 2021

PR description:

Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations.

In this PR, 6 files changed.
RecoTracker/IterativeTracking/python/ElectronSeeds_cff.py
RecoTracker/IterativeTracking/python/JetCoreRegionalStep_cff.py
RecoTracker/IterativeTracking/python/MixedTripletStep_cff.py
RecoTracker/IterativeTracking/python/PixelLessStep_cff.py
RecoTracker/IterativeTracking/python/PixelPairStep_cff.py
RecoTracker/IterativeTracking/python/TobTecStep_cff.py

This pr is originally from #33903 (now closed due to the unsuccessful rebasing in the RecoTracker/IterativeTracking/python/JetCoreRegionalStep_cff.py).

(The previous PRs were PR#33207, PR#33307, PR#33352, PR#33543, PR#33563, PR#33671, PR#33901)

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_12_0_X, the basic test all passed in the CMSSW PR instructions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34007/23132

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoTracker/IterativeTracking

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @gpetruc, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jun 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e8aab/15741/summary.html
COMMIT: 558cfc3
CMSSW: CMSSW_12_0_X_2021-06-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34007/15741/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648335
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2648300
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Jun 8, 2021

+1

  • Technical migration, as planned
  • Jenkins tests pass and show no differences in outputs

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 8, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants