Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LowPtElectrons: embed extra info in pat::Electron for BParking UL #34023

Merged

Conversation

bainbrid
Copy link
Contributor

@bainbrid bainbrid commented Jun 8, 2021

PR description:

This PR enables the LowPtElectronModifier to embed additional information in low-pT pat::Electrons for the BParking UL campaign. The additional information concerns photons conversions and impact parameter vars (dxy, dz). The modifier is enabled with the logic (bParking & run2_miniAOD_UL).

This logic is already enabled (by default) in master via PR #33817.

This PR is built on top of PR #33992, which has been recently merged.

PR validation:

Local tests before/after the change based on wf 136.898.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This logic is already enabled (by default) in master via PR #33817.

…ow-pT pat::Electrons with the logic (bParking & run2_miniAOD_UL)
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

A new Pull Request was created by @bainbrid for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bainbrid
Copy link
Contributor Author

bainbrid commented Jun 8, 2021

@slava77
Copy link
Contributor

slava77 commented Jun 8, 2021

test parameters:

  • workflows = 136.898,1304.181

@slava77
Copy link
Contributor

slava77 commented Jun 8, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6947b0/15755/summary.html
COMMIT: 6bdaa19
CMSSW: CMSSW_10_6_X_2021-06-08-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34023/15755/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215678
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215341
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Jun 9, 2021

+reconstruction

for #34023 6bdaa19

  • code changes are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no differences (the bParking UL miniAOD is not tested)
  • local test with 136.898 wf part running only PAT step with run2_miniAOD_UL on AOD produced in 10_6_25 (this represents the bParking UL miniAOD step) show expected result: there are updates in slimmedLowPtElectrons userInts and userFloats variables, the increase in miniAOD size is 1.5% (this should be OK, after a significant decrease in size in LowPtElectrons: final energy regression and ID (back port of 32391) #33589 )

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 9, 2021

+1

@cmsbuild cmsbuild merged commit f59d0ca into cms-sw:CMSSW_10_6_X Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants