Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALCA_DB] Apply code-checks/format with misc-definitions-in-headers #34033

Merged
merged 1 commit into from Jun 15, 2021
Merged

[ALCA_DB] Apply code-checks/format with misc-definitions-in-headers #34033

merged 1 commit into from Jun 15, 2021

Conversation

smuzaffar
Copy link
Contributor

code-checks/format applied on full cmssw

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34033/23167

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondFormats/SiPixelObjects

@malbouis, @yuanchao, @tlampen, @ggovi, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @VinInn, @OzAmram, @dkotlins, @ferencek, @mmusich, @seemasharmafnal, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7128e1/15774/summary.html
COMMIT: 04d86e6
CMSSW: CMSSW_12_0_X_2021-06-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34033/15774/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2862497
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

ping @cms-sw/alca-l2 @cms-sw/db-l2

@francescobrivio
Copy link
Contributor

+alca

  • technical
  • tests passed

@qliphy
Copy link
Contributor

qliphy commented Jun 14, 2021

kindly ping @cms-sw/db-l2

@smuzaffar
Copy link
Contributor Author

@ggovi , can you please sign this?

@smuzaffar
Copy link
Contributor Author

@qliphy @silviodonato , can we please merge this, it only contains code-format changes for one file

@qliphy
Copy link
Contributor

qliphy commented Jun 15, 2021

merge

@cmsbuild cmsbuild merged commit 0398ed8 into cms-sw:master Jun 15, 2021
@ggovi
Copy link
Contributor

ggovi commented Jun 15, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@smuzaffar smuzaffar deleted the 12_0-code-checks-ALCA_DB branch June 18, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants