Fix CalibFormats/SiStripObjects comp failure for gcc10

[mrodozov]

PR description:

CalibFormats/SiStripObjects failed to compile in 2300 gcc10 IB
it was missing the header for uint_32

PR validation:

CalibFormats/SiStripObjects compiles

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34076/23234

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

CalibFormats/SiStripObjects

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test

[mrodozov]

please test for CMSSW_12_0_X/slc7_amd64_gcc10

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77b024/15858/summary.html
COMMIT: 7387218
CMSSW: CMSSW_12_0_X_2021-06-09-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34076/15858/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-09-2300/src/CondTools/SiStrip/plugins/SiStripSummaryReader.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-09-2300/src/CondTools/SiStrip/plugins/SiStripThresholdBuilder.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-09-2300/src/CondTools/SiStrip/plugins/SiStripThresholdReader.cc
>> Building  edm plugin tmp/slc7_amd64_gcc10/src/CondTools/SiStrip/plugins/CondToolsSiStripPlugins/libCondToolsSiStripPlugins.so
/cvmfs/cms-ib.cern.ch/nweek-02684/slc7_amd64_gcc10/external/gcc/10.2.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCommonToolsTrackerMap
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc10/src/CondTools/SiStrip/plugins/CondToolsSiStripPlugins/libCondToolsSiStripPlugins.so] Error 1
Leaving library rule at src/CondTools/SiStrip/plugins
------- copying files from src/CondTools/SiStrip/scripts -------
>> copied CreatingTables.sh
>> copied SiStripDAQPopCon.py


[smuzaffar]

gcc10 Ibs are broken, so better to test itf or master IB and integrate if test passed OR test gcc10 with full_cmssw

[mrodozov]

I think the gcc900 will be enough for this change

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77b024/15855/summary.html
COMMIT: 7387218
CMSSW: CMSSW_12_0_X_2021-06-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34076/15855/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2862485
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34076/23244

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #34076 was updated. @yuanchao, @malbouis, @pohsun, @tlampen, @francescobrivio can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77b024/15873/summary.html
COMMIT: 71c5008
CMSSW: CMSSW_12_0_X_2021-06-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34076/15873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2862485
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@cms-sw/alca-l2 , can you please sign this?
@silviodonato , @qliphy this is just a technical fix to get gcc10 builds error free

[francescobrivio]

+alca

• technical

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1