Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep future products from UL DIGI step #34081

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jun 10, 2021

keep products added in #33996 so that they are forwarded appropriately by the HLT step.

tested with inputs from 10_6_X and HLT running

cmsDriver.py  --python_filename step3.py --eventcontent RAWSIM  --datatier GEN-SIM-RAW --fileout file:step3.root --conditions 102X_upgrade2018_realistic_v15 --customise_commands 'process.source.bypassVersionCheck = cms.untracked.bool(True)' --step HLT:2018v32 --geometry DB:Extended --filein file:step2.root --era Run2_2018,bParking  --no_exec --mc -n -1 --nThreads 8

@silviodonato
it turns out that my branch made on top of 10_2_16_UL merges clearly in 10_2_X

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Jun 10, 2021
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_10_2_X.

It involves the following packages:

SimTracker/Configuration

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@echabert, @gbenelli, @makortel, @robervalwalsh, @pieterdavid, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @prolay, @mtosi, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Jun 10, 2021

@jpata @elusian

@slava77
Copy link
Contributor Author

slava77 commented Jun 10, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd766c/15868/summary.html
COMMIT: d5aa7f6
CMSSW: CMSSW_10_2_X_2021-06-08-2300/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34081/15868/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007352
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jun 10, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@slava77
Copy link
Contributor Author

slava77 commented Jun 10, 2021

formally, this is a backport of #33774

@qliphy
Copy link
Contributor

qliphy commented Jun 11, 2021

+1

@cmsbuild cmsbuild merged commit dd8ae07 into cms-sw:CMSSW_10_2_X Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants