New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More dependencies needed for UBSAN builds #34102
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34102/23293
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: CalibTracker/SiStripHitEfficiency @malbouis, @civanch, @Dr15Jones, @ahmad3213, @makortel, @kmaeshima, @cvuosalo, @andrius-k, @kpedro88, @ianna, @cmsbuild, @yuanchao, @srimanob, @jfernan2, @mdhildreth, @tlampen, @ErnestaP, @pohsun, @rvenditti, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28efaf/15922/summary.html Comparison SummarySummary:
|
+1 |
+alca |
+Upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Followup to #33933, this fixes two more missing dependencies in UBSAN builds,
and
This also adds comments for the two entries here and the ones in #33933 to document why the dependency is needed.
PR validation:
Trivial technical fix, compiles in CMSSW_12_0_UBSAN_X_2021-06-11-2300.