Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dependencies needed for UBSAN builds #34102

Merged
merged 2 commits into from Jun 14, 2021

Conversation

dan131riley
Copy link

PR description:

Followup to #33933, this fixes two more missing dependencies in UBSAN builds,

CalibTrackerSiStripHitEfficiency/HitEff.cc.o:(.data.rel+0x3d18): undefined reference to `typeinfo for LumiScalers'

and

DQMDTMonitorModule/DTScalerInfoTask.cc.o:(.data.rel+0x3bd8): undefined reference to `typeinfo for LumiScalers'

This also adds comments for the two entries here and the ones in #33933 to document why the dependency is needed.

PR validation:

Trivial technical fix, compiles in CMSSW_12_0_UBSAN_X_2021-06-11-2300.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34102/23293

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

CalibTracker/SiStripHitEfficiency
DQM/DTMonitorModule
DQM/TrackerRemapper
Geometry/MTDNumberingBuilder

@malbouis, @civanch, @Dr15Jones, @ahmad3213, @makortel, @kmaeshima, @cvuosalo, @andrius-k, @kpedro88, @ianna, @cmsbuild, @yuanchao, @srimanob, @jfernan2, @mdhildreth, @tlampen, @ErnestaP, @pohsun, @rvenditti, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @hdelanno, @battibass, @makortel, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28efaf/15922/summary.html
COMMIT: 3d72609
CMSSW: CMSSW_12_0_X_2021-06-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34102/15922/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2862497
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@francescobrivio
Copy link
Contributor

+alca

@srimanob
Copy link
Contributor

+Upgrade

@civanch
Copy link
Contributor

civanch commented Jun 14, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 14, 2021

+1

@cmsbuild cmsbuild merged commit 5d65f68 into cms-sw:master Jun 14, 2021
@dan131riley dan131riley deleted the ubsan-dependencies branch June 14, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants