Remove unnecessary call that causes unloading in ROOT6 #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_1_X. Remove unnecessary call that causes unloading in ROOT6 It involves the following packages: IOPool/TFileAdaptor @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
ktf
added a commit
that referenced
this pull request
Apr 22, 2014
ROOT6 -- Remove unnecessary call that causes unloading in ROOT6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor of our TFileAdaptor service made an unnecessary call to the ROOT function TPluginManager::LoadHandlersFromPluginDirs(). In ROOT 5, this call was unnecessary, but caused no observed problems. In ROOT 6, this causes unnecessary unloading and reloading of ROOT plugins. CMS has no need for unloading, ever.
This pull request will remove the same call in the 7_1_X branch (ROOT5). This maintains code commonality, and removes an unnecessary call that may adversely affect performance.