Cleanup of BTV OfflineDQM

[marco-link]

PR description:

• remove of old taggers from OfflineDQM:

  • combMVAv2
  • CSVTag
  • CSVv2
  • Ctagger
  • CtaggerTag
  • JBP
  • SET
  • SISVHE
  • SMT
  • SSVHE
  • TCHE

• extend jet eta range in histograms from 2.4 to 2.5

• remove now deprecated module MVAJetTagPlotter (affected by Migrate ED modules to use esConsumes #31061)

PR validation:

runTheMatrix.py -l 136.891 and runTheMatrix.py -l 12034.0 to verify DQMOffline histograms are filled correctly

runTheMatrix.py -l limited -i all --ibeos with some unrelated failures:

----- Begin Fatal Exception 16-Jun-2021 11:33:13 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=PoolDBESSource label='GlobalTag'
Exception Message:
A std::exception was thrown.
Connection on "frontier://(preferipfamily=0)(proxyconfigurl=http://grid-wpad/wpad.dat)(backupproxyurl=http://cmst0frontier.cern.ch:3128)(backupproxyurl=http://cmst0frontier1.cern.ch:3128)(backupproxyurl=http://cmst0frontier2.cern.ch:3128)(backupproxyurl=http://cmsbpfrontier.cern.ch:3128)(backupproxyurl=http://cmsbpfrontier1.cern.ch:3128)(backupproxyurl=http://cmsbpfrontier2.cern.ch:3128)(backupproxyurl=http://cmsbproxy.fnal.gov:3128)(serverurl=http://cmsfrontier.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier1.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier2.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier3.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier4.cern.ch:8000/FrontierProd)/CMS_CONDITIONS" cannot be established ( CORAL : "ConnectionPool::getSessionFromNewConnection" from "CORAL/Services/ConnectionService" )
----- End Fatal Exception -------------------------------------------------

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34156/23357

• This PR adds an extra 40KB to repository

• Found files with invalid states:

  • RecoBTag/Combined/python/pfDeepFlavourDiscriminatorsJetTags_cfi.py:
    • Added: 18fa48e
    • Deleted: 6d2cf77

[cmsbuild]

A new Pull Request was created by @marco-link for master.

It involves the following packages:

DQMOffline/RecoB

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@ferencek, @JyothsnaKomaragiri, @emilbols, @andrzejnovak, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[jfernan2]

Thanks @marco-link !!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32912a/15999/summary.html
COMMIT: 53ccbc7
CMSSW: CMSSW_12_0_X_2021-06-16-0900/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34156/15999/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2772870
• DQMHistoTests: Total failures: 4117
• DQMHistoTests: Total nulls: 727
• DQMHistoTests: Total successes: 2768004
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -39263.473 KiB( 37 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -42.583 KiB Btag/TagCorrelation_pfCombinedCvsBJetTags_vs_pfCombinedCvsLJetTags_ETA_1v4-2v4
• DQMHistoSizes: changed ( 1000.0 ): -42.575 KiB Btag/TagCorrelation_pfCombinedCvsBJetTags_vs_pfCombinedCvsLJetTags_ETA_0-1v4
• DQMHistoSizes: changed ( 1000.0 ): -42.563 KiB Btag/TagCorrelation_pfCombinedCvsBJetTags_vs_pfCombinedCvsLJetTags_GLOBAL
• DQMHistoSizes: changed ( 1000.0 ): 2.137 KiB Btag/IPTag_ETA_1v4-2v5
• DQMHistoSizes: changed ( 1000.0 ): -2.137 KiB Btag/IPTag_ETA_1v4-2v4
• DQMHistoSizes: changed ( 1000.0 ): -0.573 KiB Btag/deepCSV_BvsAll_ETA_1v4-2v4
• DQMHistoSizes: changed ( 1000.0 ): 0.573 KiB Btag/deepCSV_BvsAll_ETA_1v4-2v5
• DQMHistoSizes: changed ( 1000.0 ): -0.565 KiB Btag/Ctagger_CvsB_ETA_1v4-2v4
• DQMHistoSizes: changed ( 1000.0 ): -0.565 KiB Btag/deepCSV_CvsB_ETA_1v4-2v4
• DQMHistoSizes: changed ( 1000.0 ): -0.565 KiB Btag/deepCSV_CvsL_ETA_1v4-2v4
• DQMHistoSizes: changed ( 1000.0 ): ...
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[jfernan2]

Thank you very much for this cleaning @marco-link !!

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1