Run2-TB61 Modify the cfg's for testbeam simulation of the combined calorimeter ECAL+HCAL

[bsunanda]

PR description:

Modify the cfg's for testbeam simulation of the combined calorimeter ECAL+HCAL

PR validation:

Test by running all the cfg's in SimG4CMS/HcalTestBeam/test/python and Geometry/HcalTestBeamData/test/python

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34162/23368

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HcalTestBeamData
SimG4CMS/HcalTestBeam

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84f53e/16062/summary.html
COMMIT: 44c9495
CMSSW: CMSSW_12_0_X_2021-06-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34162/16062/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862497
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[civanch]

@bsunanda , as far as I remember the max time in TB 2006 was 1000 ns, also why you need to change MaxZCentralCMS?

[bsunanda]

The common_maximum_timex is used in the local definition of PS SteepingAction and CaloSD. Running the code complained about missing parameter MaxTrackTimeForward and MaxZCentralCMS - so I copied the ones from default g4SimHits there

[civanch]

There is not need to reduce the default value.

[bsunanda]

This is the default value but since SteppingAction is redefined here, I have to add this

[civanch]

@bsunanda , I would keep g4SimHits parameters unchanged if they are not modified. Only beam properties and time cut are different in TB and in the data, also you add recently the list of SDs. I would not redefine MaxNumberOfSteps and similar parameters - they are included for a particular use case and may disappear in future.

[bsunanda]

@civanch I wanted to have the cfg's functional. Ince I added list of SD's, running the cfg's complained about missing parameters. So I copied the ones from g4SimHits in appropriate places. Most likely we need to revise all these cfg's later on and seeing the changed parameters from defaults and changing these.

[civanch]

+1

I agree, that this is a working solution but likely in future scripts will require modifications.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1