Replace deprecated ext/hash_map with std::unordered_map

[guitargeek]

PR description:

The PR replaces the deprecated ext/hash_map with std::unordered_map. This fixes build warnings I saw in my CMSSW builds.

PR validation:

CMSSW compilers

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34190/23406

• This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34190/23406/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34190/23406/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34190/23407

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CalibTracker/SiStripQuality
CondTools/SiPixel
CondTools/SiStrip
L1Trigger/GlobalTrigger
L1Trigger/L1TGlobal

@malbouis, @yuanchao, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @OzAmram, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @VinInn, @Martin-Grunewald, @dkotlins, @ferencek, @mmusich, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[qliphy]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d34d77/16122/summary.html
COMMIT: 8d90540
CMSSW: CMSSW_12_0_X_2021-06-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34190/16122/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785631
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2785596
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[yuanchao]

+1

• migrate ext/hash_map to std::unordered_map
• WF matrix tests and unit tests passed

[guitargeek]

@ggovi, is this okay for db?

[qliphy]

ping @cms-sw/db-l2

[guitargeek]

Hi @qliphy, can this be merged? The db review was requested because of changes to the CondTools subsystem, but the changes where only that unused includes were removed.

[qliphy]

+1

[qliphy]

merge

[Dr15Jones]

Thanks!