Cast indexFor to unsigned for size comparison

[mrodozov]

PR description:

Adjustment for catch2 2.13.6
It seems that indexFor was returning unsigned before and does int now and it's compared with int in both cases

PR validation:

All packages which use the catch2 external compile, hope I picked them all

[mrodozov]

please test with cms-sw/cmsdist#7053

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34205/23438

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

CondFormats/EcalObjects
FWCore/Framework

@smuzaffar, @Dr15Jones, @malbouis, @makortel, @yuanchao, @tlampen, @ggovi, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @makortel, @wddgit, @thomreis, @simonepigazzini, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-304b16/16161/summary.html
COMMIT: 8af1172
CMSSW: CMSSW_12_0_X_2021-06-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34205/16161/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785631
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785602
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[yuanchao]

+1

• type casting on covariance index (technical)
• matrix tests and unit tests passed

[smuzaffar]

@ggovi , can you please review this? This is needed to update catch2 externals to a newer version 2.13.6. Thanks,

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1