Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPayloadData unit test, if no plugins are found, look in the CMSSW_RELEASE_BASE #34257

Merged
merged 2 commits into from Jun 26, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 26, 2021

PR description:

Solves issue reported at #34199 (comment)

PR validation:

Run the unit test without compiling the package and found all the registered plugins in the release.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport is needed.

…RELEASE_BASE or CMSSW_FULL_RELEASE_BASE in case of patch releases
@mmusich mmusich force-pushed the getPayloadData_fixCaseForUnitTest branch from 11e1119 to 1fe632c Compare June 26, 2021 10:05
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34257/23542

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 26, 2021

@cmsbuild, please test

…RELEASE_BASE or CMSSW_FULL_RELEASE_BASE in case of patch releases
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34257/23543

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34257 was updated. @ggovi, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 26, 2021

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Jun 26, 2021

@cmsbuild please test

@mmusich
Copy link
Contributor Author

mmusich commented Jun 26, 2021

urgent

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a01179/16255/summary.html
COMMIT: 7123d60
CMSSW: CMSSW_12_0_X_2021-06-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34257/16255/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785688
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@silviodonato , @qliphy , I am merging this to fix the unit test for IBs. This should not break any thing else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants