Migrate to esConsumes Alignment/CommonAlignmentMonitor

[mmusich]

PR description:

The main goal of this PR is to finalize the migration to esConsumes for the package Alignment/CommonAlignmentMonitor.
I profit of it to modernize some of the legacy edm::EDProducers to become thread-efficient.
This is part of issue #31061.
As a not the code in Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorTracksFromTrajectories.cc seems heavily changed, though I didn't modify much that file. Most of the differences come from code-formatting (which is a prerequisite to pass integration tests).

PR validation:

The code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and not backport will be needed.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34270/23569

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorAsAnalyzer.cc modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34270/23569/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34270/23569/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34270/23570

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorAsAnalyzer.cc modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/CommonAlignmentMonitor

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4eaafe/16275/summary.html
COMMIT: 4fe7330
CMSSW: CMSSW_12_0_X_2021-06-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34270/16275/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-28-1100/src/Alignment/CommonAlignmentProducer/src/AlignmentSeedSelector.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-28-1100/src/Alignment/CommonAlignmentProducer/src/AlignmentTrackSelector.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-28-1100/src/Alignment/CommonAlignmentProducer/src/AlignmentTracksFromVertexSelector.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-28-1100/src/Alignment/CommonAlignmentProducer/src/AlignmentTwoBoyDecayTrackSelector.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-28-1100/src/Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc: In member function 'void AlignmentProducerBase::createMonitors()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-28-1100/src/Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc:295:106: error: no matching function for call to 'edmplugin::PluginFactory::create(const std::__cxx11::basic_string&, const edm::ParameterSet&)'
  295 |         AlignmentMonitorPluginFactory::get()->create(miter, monitorConfig.getUntrackedParameterSet(miter)));
      |                                                                                                          ^
In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-06-28-1100/src/Alignment/CommonAlignmentAlgorithm/interface/AlignmentAlgorithmPluginFactory.h:10,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-28-1100/src/Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc:5:
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-06-28-1100/src/FWCore/PluginManager/interface/PluginFactory.h:63:24: note: candidate: 'std::unique_ptr<_Tp> edmplugin::PluginFactory::create(const string&, Args ...) const [with R = AlignmentMonitorBase; Args = {const edm::ParameterSet&, edm::ConsumesCollector&}; std::string = std::__cxx11::basic_string]'


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34270/23572

• This PR adds an extra 72KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorAsAnalyzer.cc modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120
  • File Alignment/CommonAlignmentProducer/interface/AlignmentProducerBase.h modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120
  • File Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

[cmsbuild]

Pull request #34270 was updated. @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please check and sign again.

[mmusich]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4eaafe/16283/summary.html
COMMIT: 095d7fc
CMSSW: CMSSW_12_0_X_2021-06-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34270/16283/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 3 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4eaafe/16283/llvm-analysis/esrget-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785688
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[yuanchao]

+1

• migrate to esConsumes for Alignment/CommonAlignmentMonitor (remainings are in /Alignment/CommonAlignmentProducer)
• matrix tests and unit tests all passed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1