New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize file size for MatacqProducer::msize #34279
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34279/23581
|
A new Pull Request was created by @perrotta for master. It involves the following packages: EventFilter/EcalRawToDigi @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c77bc5/16315/summary.html Comparison SummarySummary:
|
3a907cf
to
6f02448
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34279/23604
|
please test |
Initialization moved outside the method, per suggestion of @slava77 (and I also realized that a more appropriate initialization value is "-1", rather than "0") |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c77bc5/16343/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fix a missing initialization inside MatacqProducer::msize
Pointed out by the static analyzer
PR validation:
Rather trivial fix. It builds
No changes expected