add gil acquire when modifying python object

[davidlange6]

Addresses unit test crash seen in python3.9 upgrade.
(discussion in cms-sw/cmsdist#7065)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34288/23602

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

FWCore/PythonFramework

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

…

On Jun 30, 2021, at 3:51 PM, cmsbuild ***@***.***> wrote: A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FWCore/PythonFramework @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. @makortel, @wddgit this is something you requested to watch as well. @silviodonato, @dpiparo, @qliphy you are the release manager for this. cms-bot commands are listed here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d74b0b/16341/summary.html
COMMIT: 5bc8edb
CMSSW: CMSSW_12_0_X_2021-06-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34288/16341/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Moved using namespace within PyBind11 function #34280 @Dr15Jones: Moved using namespace within PyBind11 function
• [HGCAL] Fill regressed energy for SimTracksters #34276 @felicepantaleo: [HGCAL] Fill regressed energy for SimTracksters
• Run3-hcx298 Correct the scripts for Geometry related to DB for HCAL #34267 @bsunanda: Run3-hcx298 Correct the scripts for Geometry related to DB for HCAL
• Speed up Patatrack CA #34250 @VinInn: Speed up Patatrack CA
• Updates for Run-3 CSC trigger primitives #34245 @dildick: Updates for Run-3 CSC trigger primitives
• RFC: [DQM] First prototype of nanoDQMIO with single LS granularity #34220 @jfernan2: RFC: [DQM] First prototype of nanoDQMIO with single LS granularity

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d74b0b/16341/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d74b0b/16341/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 209
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785480
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test for CMSSW_12_0_DEVEL_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d74b0b/16360/summary.html
COMMIT: 5bc8edb
CMSSW: CMSSW_12_0_DEVEL_X_2021-06-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34288/16360/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Moved using namespace within PyBind11 function #34280 @Dr15Jones: Moved using namespace within PyBind11 function
• [HGCAL] Fill regressed energy for SimTracksters #34276 @felicepantaleo: [HGCAL] Fill regressed energy for SimTracksters
• Run3-hcx298 Correct the scripts for Geometry related to DB for HCAL #34267 @bsunanda: Run3-hcx298 Correct the scripts for Geometry related to DB for HCAL
• Speed up Patatrack CA #34250 @VinInn: Speed up Patatrack CA
• Updates for Run-3 CSC trigger primitives #34245 @dildick: Updates for Run-3 CSC trigger primitives
• RFC: [DQM] First prototype of nanoDQMIO with single LS granularity #34220 @jfernan2: RFC: [DQM] First prototype of nanoDQMIO with single LS granularity

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d74b0b/16360/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d74b0b/16360/git-merge-result

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 6397 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 3871
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2781799
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.703 KiB( 37 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+core

• It fixes the DEVEL IBs unit test
• comparison differences are not due to this PR, as it only updates file in the tests area

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1