Fix crash in ECAL local reco on GPU if ECAL is not in the run

[thomreis]

PR description:

This should fix crashes of the ECAL local reconstruction on GPU if the ECAL is not in the run as described in #34197
The changes to EcalRecHitProducerGPU.cc were not needed to fix the crash since currently the RecHits are produced on CPU only by default. However, the protection against empty inputs was added nevertheless to avoid the same issue in the future.

PR validation:

Processing of run 342110, for which ECAL was not in the run, does not crash anymore with these changes.

[thomreis]

type bugfix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34292/23605

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalCalo/EcalRecProducers/plugins/EcalRecHitProducerGPU.cc modified in PR(s): ECAL esConsumes migrations in EventFilter and RecoLocalCalo #34273

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

EventFilter/EcalRawToDigi
RecoLocalCalo/EcalRecProducers

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @Martin-Grunewald, @apsallid, @thomreis, @simonepigazzini this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0aa25/16355/summary.html
COMMIT: 07a68aa
CMSSW: CMSSW_12_0_X_2021-06-29-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34292/16355/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 8 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0aa25/16355/llvm-analysis/esrget-sa.txt for details.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19723
• DQMHistoTests: Total failures: 118
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19605
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785688
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34292 07a68aa

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show no (relevant) differences
  • some differences in 10824.502 are not related to this PR and come from non-repeatable results of pixel tracking on GPU

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1