Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with SiPixelQualityMapComparisonBase #34326

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 4, 2021

PR description:

This is a follow-up to PR #34071.
Fixes two issues found when displaying plots in the payload inspector in CondDB:

  • changes the template arguments for SiPixel*QualityMapCompareTwoTags in order to be in single IOV mode;
  • fix the issue with Phase1PixelROCMaps the in "delta" mode, when an empty map was produced (leading to division by zero); such case is now tested in the unit tests.

PR validation:

Tested with the command:

getPayloadData.py --plugin pluginSiPixelQuality_PayloadInspector --plot plot_SiPixelBPixQualityMapCompareSingleTag --tag SiPixelQuality_v04_offline --input_params '{}' --time_type Run --iovs '{"start_iov": "319320", "end_iov": "319547"}' --db Prod --test;

which was failing before (killed) while now produces:

abeb896c-647b-4c1e-a110-89333c27306f

Also the (augmented) unit test pass.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 4, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34326/23675

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiPixelPlugins
DQM/TrackerRemapper

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @ggovi, @rvenditti can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @VinInn, @OzAmram, @dkotlins, @fioriNTU, @jandrea, @ferencek, @idebruyn, @mmusich, @threus, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34326/23676

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2021

Pull request #34326 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @ggovi, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 4, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-658959/16451/summary.html
COMMIT: 1d127cf
CMSSW: CMSSW_12_0_X_2021-07-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34326/16451/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785924
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785889
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34326/23683

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

Pull request #34326 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @ggovi, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 5, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-658959/16458/summary.html
COMMIT: b982aff
CMSSW: CMSSW_12_0_X_2021-07-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34326/16458/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785924
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 5, 2021

+1

@mmusich
Copy link
Contributor Author

mmusich commented Jul 6, 2021

@ggovi can you please sign this?
It would be highly desirable to have in 12_0_0_pre4.
Thanks

@ggovi
Copy link
Contributor

ggovi commented Jul 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 7, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants