Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed uninitialized variable in PFTau3ProngSummary #3436

Conversation

Dr15Jones
Copy link
Contributor

PFTau3ProngSummary::Tau_Charge was returning an undefined value
since it was using a uninitialized stack variable as its charge
summing variable. The problem was found by the static analyzer.

PFTau3ProngSummary::Tau_Charge was returning an undefined value
since it was using a uninitialized stack variable as its charge
summing variable. The problem was found by the static analyzer.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Fixed uninitialized variable in PFTau3ProngSummary

It involves the following packages:

DataFormats/TauReco

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 24, 2014

+1

for #3436 7cd92fc

tested in CMSSW_7_1_X_2014-04-23-0200
(test area sign352)
no regressions observed on short matrix tests

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Apr 24, 2014
…au3ProngSummary

DataFormats/TauReco -- Fixed uninitialized variable in PFTau3ProngSummary
@nclopezo nclopezo merged commit e9fc268 into cms-sw:CMSSW_7_1_X Apr 24, 2014
@Dr15Jones Dr15Jones deleted the fixUninitializedVariableInPFTau3ProngSummary branch April 24, 2014 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants