[DQM] Set assertLegacySafe to False

[jfernan2]

PR description:

As suggested in #34231 (comment) assertLegacySafe parameter in DQMStore can be moved to False. The option existed to support some DQM code that did not work with concurrent lumis, but this should not be the case at present

PR validation:

runTheMatrix.py -l limited -i all --ibeos

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34366/23741

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DQMServices/Core

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

Thanks @jfernan2. Could I suggest to update the README
https://github.com/cms-sw/cmssw/blob/master/DQMServices/Core/README.md#the-dqmstore
as well about

It does not affect the behaviour. It is enabled by default, but should be disabled in production RECO jobs where concurrent lumisections are expected.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46fe11/16508/summary.html
COMMIT: 1e952d1
CMSSW: CMSSW_12_0_X_2021-07-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34366/16508/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785924
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785901
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[jfernan2]

Thanks @jfernan2. Could I suggest to update the README
https://github.com/cms-sw/cmssw/blob/master/DQMServices/Core/README.md#the-dqmstore
as well about

Done. Thanks!

[jfernan2]

+1

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34366/23754

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #34366 was updated. can you please check and sign again.

[Martin-Grunewald]

Great, thanks, this indeed fixes the problem with the TSG tests.
Please include for pre4!! @qliphy @silviodonato

[qliphy]

+1

[qliphy]

merge

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46fe11/16524/summary.html
COMMIT: bf438ff
CMSSW: CMSSW_12_0_X_2021-07-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34366/16524/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785924
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2785895
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found