Fix BeamMonitor names in BeamSpot DQM clients

[francescobrivio]

PR description:

This PR fixes the dqmEnv.subSystemFolder, dqmSaver.tag and dqmSaverPB.tag names in the BeamMonitor (and FakeBeamMonitor), so that when running the two clients in parallel the output root files are named differently and no crash should happen in DQM at the file-merging step.

PR validation:

I run locally the unit tests to confirm that the output names of the root files are changed as expected.
For example:

DQM_V0001_FakeBeamMonitor_R000325283.root   -->   DQM_V0001_FakeBeamMonitorHLT_R000325283.root

@jfernan2 I'm not sure how to test the change done for dqmEnv.subSystemFolder, any suggestion?

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backported in #34468

[francescobrivio]

FYI @mmusich @gennai @mtosi

[jfernan2]

Thanks @francescobrivio !
However, to test this at present MWGR, we need a backport to 11_3_X. Thank you

[francescobrivio]

Thanks @francescobrivio !
However, to test this at present MWGR, we need a backport to 11_3_X. Thank you

Ok I will open the backport it in 2 minutes then!

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34467/23918

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py modified in PR(s): Bianca pinolini ecal reco phase2 commit unimib #34212
  • File DQM/Integration/python/clients/beamfake_dqm_sourceclient-live_cfg.py modified in PR(s): Bianca pinolini ecal reco phase2 commit unimib #34212
  • File DQM/Integration/python/clients/beamhlt_dqm_sourceclient-live_cfg.py modified in PR(s): Bianca pinolini ecal reco phase2 commit unimib #34212
  • File DQM/Integration/python/clients/beamhltfake_dqm_sourceclient-live_cfg.py modified in PR(s): Bianca pinolini ecal reco phase2 commit unimib #34212

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• DQM/Integration (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e84e0/16768/summary.html
COMMIT: c034f6e
CMSSW: CMSSW_12_0_X_2021-07-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34467/16768/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786302
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2786267
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Tested succesfully in Online DQM at P5

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1