Pixel Local GPU reco crash on copy fix - backport to 11_3_X

[czangela]

PR description:

Fix for #34496.

Solution by @VinInn.

In short:

Reconstruction with an empty pixel detector in /RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc, failed on

std::copy(hitsModuleStart_.get(), hitsModuleStart_.get() + gpuClustering::maxNumModules + 1, hmsp.get());

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

#34501

[cmsbuild]

A new Pull Request was created by @czangela for CMSSW_11_3_X.

It involves the following packages:

• RecoLocalTracker/SiPixelRecHits (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

• Backported from Pixel Local GPU reco crash on copy fix #34501

[mmusich]

backport of #34501

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d72215/16856/summary.html
COMMIT: 1e4bc66
CMSSW: CMSSW_11_3_X_2021-07-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34503/16856/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2878314
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2878291
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #34503 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d72215/16984/summary.html
COMMIT: e107cb1
CMSSW: CMSSW_11_3_X_2021-07-18-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34503/16984/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2878314
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2878285
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34503 e107cb1

• code changes are in line with the PR description and the master branch PR Pixel Local GPU reco crash on copy fix #34501 (changes in the code are the same)
• jenkins tests pass and comparisons with the baseline show no relevant differences (a GPU test is available in Pixel Local GPU reco crash on copy fix #34501, which should be enough in this case).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1