Reserve one bit for flagging individual pixels

[tsusa]

PR description:

Change Pixel Digi Packing to reserve one bit for flagging individual pixels (needed for the foreseen PR concerning Pixel Digi Morphing).

Pixel Digi Packing was changed in #14470 to have indexes spanning the full module in case of small pixels (Phase II InnerPixel). In that PR packing was changed from (8, 9, 4, 11) -> (11, 11, 0, 10) /(row, col, time, adc) which can accommodate 2048x2048 pixels (row x column),
row = 11bits -> 2^11 = 2048, col = 11bits -> 2^11 = 2048.

With this PR the packing changes from (11, 11, 0, 10) -> (11, 10, 0, 10), reducing row x column to 2048x1024. However, this would fit all Phase II use cases (both for 25x100 μm2 and 50x50 μm2) as there are max 1354 (rows)*434 (cols) in the case of 2x2 rectangular pixel layout.

No changes are expected.

PR validation:

No failure when running runTheMatrix.py.

@emiglior, @mmusich , @veszpv

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34509/24004

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @tsusa (Tatjana Susa) for master.

It involves the following packages:

• DataFormats/SiPixelDetId (simulation)
• DataFormats/SiPixelDigi (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @VinInn, @OzAmram, @dkotlins, @ferencek, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8018f/16873/summary.html
COMMIT: 62ee660
CMSSW: CMSSW_12_0_X_2021-07-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34509/16873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786302
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786279
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[VinInn]

enable gpu

[VinInn]

Digis and DetId affect reco as well. Why reco is not notified here?

[VinInn]

@cmsbuild , please test

[mmusich]

@cms-sw/reconstruction-l2 FYI

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8018f/16891/summary.html
COMMIT: 62ee660
CMSSW: CMSSW_12_0_X_2021-07-15-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34509/16891/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19735
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19729
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786302
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786279
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1