Run3-hcx303 Add a few cfi's to help processing with DDD or DD4Hep #34569

bsunanda · 2021-07-20T18:11:58Z

PR description:

Add a few cfi's to help processing with DDD or DD4Hep

PR validation:

Use the standard workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-07-20T18:18:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34569/24112

This PR adds an extra 16KB to repository

cmsbuild · 2021-07-20T18:18:52Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Configuration/Geometry (geometry, upgrade)
Geometry/HcalCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-07-20T18:23:59Z

@cmsbuild Please test

cvuosalo · 2021-07-20T19:16:03Z

Geometry/HcalCommonData/python/hcalDDConstants_cff.py

 from Geometry.HcalCommonData.caloSimulationParameters_cff   import *
+from Geometry.HcalCommonData.hcalhcalDBConstants_cff        import *


Does hcalhcalDBConstants_cff exist? The hcalhcal part seems odd.

cmsbuild · 2021-07-20T19:48:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34569/24113

This PR adds an extra 20KB to repository

cmsbuild · 2021-07-20T19:48:51Z

Pull request #34569 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @srimanob, @mdhildreth can you please check and sign again.

cvuosalo · 2021-07-20T19:59:02Z

Geometry/HcalCommonData/python/hcalDDDSimConstants_cff.py

 from Geometry.HcalCommonData.hcalSimulationConstants_cfi    import *
 from Geometry.HcalCommonData.caloSimulationParameters_cff   import *
+from Geometry.HcalCommonData.hcalDDDSimConstants_cfi        import *


Is the order of the cfi's important?

No it is not.

Then, unless my eyes are failing me, there is no actual change to this file, and it should be removed from the PR.

What is the conclusion on this question? Thanks.

I have the ordering to be similar in all cff files. That is why it is changed here.

OK from my side. This is up to @cvuosalo.

Thanks.

bsunanda · 2021-07-20T21:51:35Z

@cmsbuild Please test

cmsbuild · 2021-07-21T05:58:49Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c2a2f/17034/summary.html
COMMIT: 4a7b2b5
CMSSW: CMSSW_12_0_X_2021-07-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34569/17034/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test2021Geometry had ERRORS
---> test test2026Geometry had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2996268
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2996245
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-07-23T16:16:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c2a2f/17147/summary.html
COMMIT: 4a7b2b5
CMSSW: CMSSW_12_0_X_2021-07-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34569/17147/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998541
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

perrotta · 2021-07-24T10:39:07Z

please test
(Since CMSSW_12_0_X_2021-07-22-1700 the issue with the missing file should have been solved)

cmsbuild · 2021-07-24T13:58:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c2a2f/17165/summary.html
COMMIT: 4a7b2b5
CMSSW: CMSSW_12_0_X_2021-07-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34569/17165/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998535
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

civanch · 2021-07-25T08:00:37Z

@cvuosalo , @srimanob, it seems that this PR is ready?

srimanob · 2021-07-25T08:24:37Z

@civanch
I see an unanswered question in the PR. Maybe we wait a bit on that for clarification?

bsunanda · 2021-07-25T13:23:50Z

I don't see why it is not approved. There are serious bug fixes in a few cff's.

srimanob · 2021-07-25T13:29:29Z

Hi @bsunanda

What is the bug that you are talking about? Can we not spot it on report (maybe I miss the bug report)?
Sorry, I don't see it in the PR description. Do you mean we have it for both DDD and DD4hep?

srimanob · 2021-07-25T13:29:36Z

+Upgrade

cvuosalo · 2021-07-25T14:12:47Z

+1

cmsbuild · 2021-07-25T14:13:12Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-07-25T14:56:36Z

+1
(Admittently @bsunanda the title and the description of this PR are not really explaining what is done here, which basically consists in setting fromDD4Hep = True in all cases in which hcalSimulationParameters are imported. If you agree, I'd update at least the description of the PR, for better bookeping)

bsunanda · 2021-07-25T20:06:07Z

@cvuosalo @perrotta @srimanob The errors were in the 2 cff's in Configuration/Geometry/python file. They were working for DDD but not for DD4Hep

Add a few cfi's to help processing with DDD or DD4Hep

cdf5ca0

cmsbuild added this to the CMSSW_12_0_X milestone Jul 20, 2021

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jul 20, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 20, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 20, 2021

cvuosalo reviewed Jul 20, 2021

View reviewed changes

Correction

4a7b2b5

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Jul 20, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 20, 2021

cvuosalo reviewed Jul 20, 2021

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jul 20, 2021

cmsbuild added tests-started and removed tests-rejected labels Jul 23, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 23, 2021

cmsbuild added tests-started and removed tests-approved labels Jul 24, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 24, 2021

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 25, 2021

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Jul 25, 2021

cmsbuild added orp-approved and removed orp-pending labels Jul 25, 2021

cmsbuild merged commit 0ce31f0 into cms-sw:master Jul 25, 2021

cmsbuild mentioned this pull request Jul 26, 2021

Added README.md to FWCore/Concurrency #34619

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-hcx303 Add a few cfi's to help processing with DDD or DD4Hep #34569

Run3-hcx303 Add a few cfi's to help processing with DDD or DD4Hep #34569

bsunanda commented Jul 20, 2021

cmsbuild commented Jul 20, 2021

cmsbuild commented Jul 20, 2021

bsunanda commented Jul 20, 2021

cvuosalo Jul 20, 2021

bsunanda Jul 20, 2021

cmsbuild commented Jul 20, 2021

cmsbuild commented Jul 20, 2021

cvuosalo Jul 20, 2021

bsunanda Jul 20, 2021

cvuosalo Jul 21, 2021

srimanob Jul 25, 2021

bsunanda Jul 25, 2021

srimanob Jul 25, 2021

bsunanda commented Jul 20, 2021

cmsbuild commented Jul 21, 2021

cmsbuild commented Jul 23, 2021

perrotta commented Jul 24, 2021

cmsbuild commented Jul 24, 2021

civanch commented Jul 25, 2021

srimanob commented Jul 25, 2021

bsunanda commented Jul 25, 2021

srimanob commented Jul 25, 2021

srimanob commented Jul 25, 2021

cvuosalo commented Jul 25, 2021

cmsbuild commented Jul 25, 2021

perrotta commented Jul 25, 2021

bsunanda commented Jul 25, 2021

		from Geometry.HcalCommonData.caloSimulationParameters_cff import *
		from Geometry.HcalCommonData.hcalhcalDBConstants_cff import *

Run3-hcx303 Add a few cfi's to help processing with DDD or DD4Hep #34569

Run3-hcx303 Add a few cfi's to help processing with DDD or DD4Hep #34569

Conversation

bsunanda commented Jul 20, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 20, 2021

cmsbuild commented Jul 20, 2021

bsunanda commented Jul 20, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Jul 20, 2021

cmsbuild commented Jul 20, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsunanda commented Jul 20, 2021

cmsbuild commented Jul 21, 2021

Unit Tests

Comparison Summary

cmsbuild commented Jul 23, 2021

Comparison Summary

perrotta commented Jul 24, 2021

cmsbuild commented Jul 24, 2021

Comparison Summary

civanch commented Jul 25, 2021

srimanob commented Jul 25, 2021

bsunanda commented Jul 25, 2021

srimanob commented Jul 25, 2021

srimanob commented Jul 25, 2021

cvuosalo commented Jul 25, 2021

cmsbuild commented Jul 25, 2021

perrotta commented Jul 25, 2021

bsunanda commented Jul 25, 2021