Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Btag threaded dqm #3457

Merged
merged 11 commits into from Apr 24, 2014
Merged

Btag threaded dqm #3457

merged 11 commits into from Apr 24, 2014

Conversation

acaudron
Copy link

Serveral changes:

  • switch to CHS jets
  • remove producer in the DQM sequence: JEC applied on the fly -> small bias in CSV tagger for example but OK for release to release comparisons
  • Able PU jets classification
  • Update configuration file to run on the GRID
  • Start switching to threaded DQM modules: implement DQMEDAnalyzer, update the way of booking the histograms using DQMStore::IBooker

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @acaudron for CMSSW_7_1_X.

Btag threaded dqm

It involves the following packages:

DQMOffline/Configuration
DQMOffline/RecoB
FastSimulation/Validation
Validation/Configuration
Validation/RecoB

@civanch, @thspeer, @deguio, @lveldere, @danduggan, @mdhildreth, @cmsbuild, @anton-a, @nclopezo, @rovere, @giamman, @slava77, @Degano, @ojeda can you please review it and eventually sign? Thanks.
@ferencek, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor

+1

@danduggan
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

@ktf - not sure when we added a fast sim signature category - but it seems with that there is no need to have a simulation signature in addition for this pull request

@ktf
Copy link
Contributor

ktf commented Apr 24, 2014

fast sim has been there since CVS ages. I'll bypass sim in any case.

ktf added a commit that referenced this pull request Apr 24, 2014
Multithreading -- Btag threaded dqm
@ktf ktf merged commit 62b1e69 into cms-sw:CMSSW_7_1_X Apr 24, 2014
@davidlange6
Copy link
Contributor

so what package is triggering a sim dependence?

On Apr 24, 2014, at 2:39 PM, Giulio Eulisse notifications@github.com
wrote:

fast sim has been there since CVS ages. I'll bypass sim in any case.


Reply to this email directly or view it on GitHub.

@ktf
Copy link
Contributor

ktf commented Apr 24, 2014

I bet it is Validation/Configuration.

On 24 Apr 2014, at 14:42, David Lange wrote:

so what package is triggering a sim dependence?

On Apr 24, 2014, at 2:39 PM, Giulio Eulisse notifications@github.com
wrote:

fast sim has been there since CVS ages. I'll bypass sim in any case.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub:
#3457 (comment)

@davidlange6
Copy link
Contributor

@ktf - seems this has triggered a bunch of printouts - can we back it out?

@acaudron
Copy link
Author

I didn't check the log of the tests from cmsbuild before but yes I see the printout now. It's strange as it was not there on my own tests. I had to check what is the problem as this message should appear only if the jets used are not PF jets.

@acaudron
Copy link
Author

the first thing is:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_1_X/Validation/RecoB/plugins/BTagPerformanceAnalyzerMC.cc#L389
I forgot to remove this "cout".

the second is:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_1_X/DQMOffline/RecoB/src/AcceptJet.cc#L64
but here I have no clue why this is printed as we run on PF jets then the dynamic cast should work.
I will try to understand it but It can be commented out for the moment, it's not a big issue.

I will try make a new pull request to fix it.

I supposed I have to make a new pull request for this

@ktf
Copy link
Contributor

ktf commented Apr 25, 2014

Yes

Sent from my iPhone

On 25/apr/2014, at 17:11, acaudron notifications@github.com wrote:

the first thing is:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_1_X/Validation/RecoB/plugins/BTagPerformanceAnalyzerMC.cc#L389
I forgot to remove this "cout".

the second is:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_1_X/DQMOffline/RecoB/src/AcceptJet.cc#L64
but here I have no clue why this is printed as we run on PF jets then the dynamic cast should work.
I will try to understand it but It can be commented out for the moment, it's not a big issue.

I will try make a new pull request to fix it.

I supposed I have to make a new pull request for this


Reply to this email directly or view it on GitHub.

@ktf
Copy link
Contributor

ktf commented Apr 25, 2014

Tra

Sent from my iPhone

On 25/apr/2014, at 17:11, acaudron notifications@github.com wrote:

the first thing is:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_1_X/Validation/RecoB/plugins/BTagPerformanceAnalyzerMC.cc#L389
I forgot to remove this "cout".

the second is:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_1_X/DQMOffline/RecoB/src/AcceptJet.cc#L64
but here I have no clue why this is printed as we run on PF jets then the dynamic cast should work.
I will try to understand it but It can be commented out for the moment, it's not a big issue.

I will try make a new pull request to fix it.

I supposed I have to make a new pull request for this


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants