Migrate module configuration in RecoMET to use default cfipython

[jeongeun]

PR description:

Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations. (The previous PRs : #33207, #33307, #33352, #33543, #33563, #33671, #34007, #34091, #34009, #34155, #34371, #34480, #34543 )

In this PR, 1 file changed.
modified: RecoMET/METPUSubtraction/python/mvaPFMET_leptons_cfi.py

Update

• Replace explicit configuration with a reference from cfipython/. (migrating EDProducer("type", .. -> typeDefaylt.clone() )
• Remove the type specifications already presented in cfipython/fillDescriptions reference for improved syntax safety.
• Remove the duplicated parameters that are exactly the same value in cfipython reference.

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_12_0_X, the basic test all passed in the CMSSW PR instructions.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34571/24117

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

• RecoMET/METPUSubtraction (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @ahinzmann, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-948bdb/17041/summary.html
COMMIT: 7ea2b96
CMSSW: CMSSW_12_0_X_2021-07-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34571/17041/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2996268
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2996245
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[perrotta]

The name of the module was hpsPFTauDiscriminationAgainstMuon2

[perrotta]

I can't find this plugin, while I see PFRecoTauDiscriminationByMVAIsolationRun2 and PFRecoTauDiscriminationByIsolationMVA2 instead
@mbluj @swozniewski is it just me, or this configuration is outdated by now?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34571/24200

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #34571 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-948bdb/17200/summary.html
COMMIT: 0620244
CMSSW: CMSSW_12_0_X_2021-07-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34571/17200/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998535
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[perrotta]

@camclean @alefisico , perhaps the question about the update status of the configurations in RecoMET/METPUSubtraction/python/mvaPFMET_leptons_cfi.py is better addressed to you than to the tau contacts.
My suspect is that either that config is never used since a while already and can be removed, or it has to be updated in order to configure (at least) exhisting plugins.
Could you please have a look and provide your opinion?

[perrotta]

@camclean @alefisico , perhaps the question about the update status of the configurations in RecoMET/METPUSubtraction/python/mvaPFMET_leptons_cfi.py is better addressed to you than to the tau contacts.
My suspect is that either that config is never used since a while already and can be removed, or it has to be updated in order to configure (at least) exhisting plugins.
Could you please have a look and provide your opinion?

I understand that in summer it can be hard to find people around... Let try with the JetMet conveners now: @lathomas @kirschen

[slava77]

@camclean @alefisico , perhaps the question about the update status of the configurations in RecoMET/METPUSubtraction/python/mvaPFMET_leptons_cfi.py is better addressed to you than to the tau contacts.
My suspect is that either that config is never used since a while already and can be removed, or it has to be updated in order to configure (at least) exhisting plugins.
Could you please have a look and provide your opinion?

I understand that in summer it can be hard to find people around... Let try with the JetMet conveners now: @lathomas @kirschen

[a weekly reminder]

[jpata]

I opened an issue for the dead code #34839 so we can meanwhile move forward with this.

[jpata]

+reconstruction

• technical, migrates python configs
• no differences were observed in the tests

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Succesfully tested 16 days ago, but sit is a simple update, and quite likely the affected config is not even used (see outdated/unused RecoMET/METPUSubtraction #34839)