New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-hcx304 Update the scripts for the combined ECAL+HCAL TB simulation #34609
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34609/24177
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34609/24183
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b8e55/17169/summary.html Comparison SummarySummary:
|
@@ -11,8 +11,8 @@ | |||
// | |||
|
|||
// user include files | |||
#include "HcalTB06Histo.h" | |||
#include "HcalTB06BeamSD.h" | |||
#include "SimG4CMS/HcalTestBeam/plugins/HcalTB06Histo.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda , this modification is fine in general but is it really needed or it is kind of cosmetic change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, all these should be better reverted: inclusions from the same plugin directory should remain without indicating the full address (in order to avoid that in case someone move or copy this code elsewhere there are inclusions from a different plugin directory)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am reverting them
+1 |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34609/24193
|
Pull request #34609 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b8e55/17181/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Update the scripts for the combined ECAL+HCAL TB simulation
PR validation:
Tested using scripts within SimG4CMS/HcalTestBeam/test/python together with #34589
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special