Fix crash on edit of Jet collection after view destruction

[alja]

PR description:

Fix crash when editing Jets, METs, or Taus after projected view destruction.

[alja]

+1

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34655/24264

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34655/24264/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34655/24264/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[alja]

+1

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34655/24269

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @alja (Alja Mrak-Tadel) for master.

It involves the following packages:

• Fireworks/Calo (visualization)

can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf6aa7/17270/summary.html
COMMIT: 842f1fa
CMSSW: CMSSW_12_0_X_2021-07-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34655/17270/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cvuosalo [DD4hep] Tool for creation of DD4hep geometry DB payloads and for migration validation #34111
• @Dr15Jones Add missing esConsumes to L1FPGATrackProducer #34635
• @Dr15Jones Remove unnecessary call to EventSetup in RPCTechnicalTrigger #34627
• @Dr15Jones Added esConsumes to L1TTwinMuxProducer #34624
• @CTPPS esConsumes in CondTools/CTPPS #34377
• @bsunanda Phase2-gex85 Update cfg's in Validation/Geometry/test in view of changes for SD's #34622
• @Dr15Jones Add esConsumes to OmtfPacker and OmtfUnpacker #34630
• @perrotta Remove unneeded computations in L1Trigger/L1TMuon and L1Trigger/L1TMuonEndCap #34620
• @fabiocos MTD geometry: fix scenario I14 for material budget studies #34625
• @kdlong Avoid rerunning particlelevel producer in NanoAOD #34590
• @Dr15Jones Add esConsumes for code using TransientTrack::setES #34584
• @guitargeek Merge .h and .cc files of plugins in several PhysicsTools packages #34594
• @dildick Speed up the CSC trigger emulator for Run-3 and Phase-2 #34638
• @bsunanda Run3-alca189 Add a few Hcal related AlCaReco streams (HcalCalIterativePhiSym, HcalCalHBHEMuonFilter, HcalCalHO, HcalCalIsoTrkFilter) to the physics data stream HLTPhysics #34628

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf6aa7/17270/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf6aa7/17270/git-merge-result

RelVals-INPUT

• 13992501.013992501.0_ZMM_13_HS+ZMM_13_HSINPUT+DIGIUP15_PU25HS+RECOUP15_PU25HS+HARVESTUP15_PU25/step2_ZMM_13_HS+ZMM_13_HSINPUT+DIGIUP15_PU25HS+RECOUP15_PU25HS+HARVESTUP15_PU25.log
• 1355.0DAS Error
• 205.0DAS Error

Expand to see more relval errors ...

• 11024.2
• 50200.0
• 50206.0
• 10006.0
• 10823.0
• 10825.0
• 250202.18

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1303 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 3677
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2994845
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.699 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 8 / 38 workflows

[qliphy]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf6aa7/17278/summary.html
COMMIT: 842f1fa
CMSSW: CMSSW_12_0_X_2021-07-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34655/17278/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cvuosalo [DD4hep] Tool for creation of DD4hep geometry DB payloads and for migration validation #34111
• @Dr15Jones Add missing esConsumes to L1FPGATrackProducer #34635
• @Dr15Jones Remove unnecessary call to EventSetup in RPCTechnicalTrigger #34627
• @Dr15Jones Added esConsumes to L1TTwinMuxProducer #34624
• @CTPPS esConsumes in CondTools/CTPPS #34377
• @bsunanda Phase2-gex85 Update cfg's in Validation/Geometry/test in view of changes for SD's #34622
• @Dr15Jones Add esConsumes to OmtfPacker and OmtfUnpacker #34630
• @perrotta Remove unneeded computations in L1Trigger/L1TMuon and L1Trigger/L1TMuonEndCap #34620
• @fabiocos MTD geometry: fix scenario I14 for material budget studies #34625
• @kdlong Avoid rerunning particlelevel producer in NanoAOD #34590
• @Dr15Jones Add esConsumes for code using TransientTrack::setES #34584
• @guitargeek Merge .h and .cc files of plugins in several PhysicsTools packages #34594
• @dildick Speed up the CSC trigger emulator for Run-3 and Phase-2 #34638
• @bsunanda Run3-alca189 Add a few Hcal related AlCaReco streams (HcalCalIterativePhiSym, HcalCalHBHEMuonFilter, HcalCalHO, HcalCalIsoTrkFilter) to the physics data stream HLTPhysics #34628

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf6aa7/17278/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf6aa7/17278/git-merge-result

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1303 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 3677
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2994845
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.699 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 8 / 38 workflows

[qliphy]

+1