Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PF][clang-tidy] fix readability-container-size-empty warnings #34658

Merged
merged 1 commit into from Jul 29, 2021
Merged

[PF][clang-tidy] fix readability-container-size-empty warnings #34658

merged 1 commit into from Jul 29, 2021

Conversation

smuzaffar
Copy link
Contributor

Thsi shoudl fix clang-tidy check readability-container-size-empty warnings which are coming from GETREF macro

DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:409:48: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
reco::TrackRef PFCandidate::trackRef() const { GETREF(reco::Track, kRefTrackMask, kRefTrackBit); }
                                               ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4661:9: note: expanded from macro 'GETREF'
    if (refsCollectionCache_.size() == 0 || refsCollectionCache_[aIndex] == 0)           \

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34658/24270

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • DataFormats/ParticleFlowCandidate (reconstruction)

@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@cbernet, @lgray, @rovere, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-791c50/17271/summary.html
COMMIT: d7871b8
CMSSW: CMSSW_12_0_X_2021-07-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34658/17271/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 250206.18DAS Error

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1302 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 3677
  • DQMHistoTests: Total nulls: 20
  • DQMHistoTests: Total successes: 2994845
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -45.699 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Jul 28, 2021

+reconstruction

for #34658 d7871b8

  • technical
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Technical, no changes in outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants