[Misc1][clang-tidy] make deleted function public

[smuzaffar]

Cleanup for clang-tidy warning deleted member function should be public [modernize-use-equals-delete]

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34689/24314

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• MagneticField/UniformEngine (reconstruction)
• PhysicsTools/CondLiteIO (analysis)
• TrackingTools/TrackAssociator (reconstruction)
• TrackingTools/TrackFitters (reconstruction)
• Utilities/StorageFactory (core)
• Validation/EcalHits (dqm)
• Validation/Geometry (geometry, dqm)
• Validation/HcalHits (dqm)

@perrotta, @smuzaffar, @civanch, @Dr15Jones, @kmaeshima, @cvuosalo, @andrius-k, @mdhildreth, @ianna, @cmsbuild, @makortel, @jfernan2, @ahmad3213, @slava77, @jpata, @ErnestaP, @santocch, @rvenditti can you please review it and eventually sign? Thanks.
@felicepantaleo, @abbiendi, @argiro, @bsunanda, @wddgit, @thomreis, @rishabhCMS, @mmusich, @cericeci, @vargasa, @makortel, @abdoulline, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @sscruz, @simonepigazzini, @trocino, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @hatakeyamak, @ebrondol, @mtosi, @fabiocos, @rbartek, @namapane, @HuguesBrun, @rchatter, @Fedespring, @calderona, @lecriste, @gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e2b5c/17334/summary.html
COMMIT: f6ca115
CMSSW: CMSSW_12_0_X_2021-07-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34689/17334/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

• 11604.0
• 11605.0
• 11606.0
• 11607.0
• 11608.0
• 11609.0
• 11630.0
• 11634.0
• 11634.1
• 11634.24
• 11634.5
• 11634.501
• 11634.505
• 11650.0
• 11650.501
• 11634.511
• 11634.521
• 11634.91
• 11634.7
• 11640.0
• 11643.0
• 11646.0
• 11650.505
• 11723.17
• 11725.0
• 11834.0
• 11834.13
• 11834.24
• 11846.0
• 11925.0
• 12034.0
• 12434.0
• 12634.0
• 12834.0
• 13034.0
• 23434.21
• 23434.99
• 23434.9921
• 34834.21
• 34834.9921

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998529
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34689 f6ca115

• technical

[civanch]

+1

[makortel]

+core

[jfernan2]

+1

[perrotta]

+1

• Technical, no changes in outputs
• This is simple and can be merged, but please @cms-sw/analysis-l2 comment if you have comments

[perrotta]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing).