[L1] Move public headers to interface directory

[smuzaffar]

As reported in #34718 , this PR moves headers in interface directory for L1

      2 src/L1Trigger/CSCTrackFinder/src/CSCTFDTReceiver.h
      1 src/L1Trigger/DTTrackFinder/src/L1MuDTTFConfig.h
      6 src/L1Trigger/TextToDigi/src/SourceCardRouting.h

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34746/24407

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)
• EventFilter/GctRawToDigi (l1)
• L1Trigger/CSCTrackFinder (l1)
• L1Trigger/DTTrackFinder (l1)
• L1Trigger/TextToDigi (l1)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5aa9/17471/summary.html
COMMIT: 61ab511
CMSSW: CMSSW_12_1_X_2021-08-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34746/17471/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 10 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5aa9/17471/llvm-analysis/esrget-sa.txt for details.
CMS StaticAnalyzer warnings: There are 2 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5aa9/17471/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1299 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 3672
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2994851
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.703 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Suggested change

	#include "../interface/SourceCardRouting.h" //hh"
	#include "L1Trigger/TextToDigi/interface/SourceCardRouting.h"

[perrotta]

@smuzaffar do you agree with this suggestion?

[smuzaffar]

CMS Naming, Coding, And Style Rules allows the use of ../interface/ , so I would suggest to leave it as it is. If needed we can update it in an other PR

[perrotta]

@smuzaffar I have merged, but in reality note 4 says:

Include only files that are in the current directory, e.g.
#include "some_header.h"
or in the .../interface directory, e.g
#include "Subsystem/Package/interface/some_header.h"

where for the .../interface directory it explicitely writes down the full path

[smuzaffar]

ah right, I will open a PR to fix this

[slava77]

perhaps we need to update the rules, it looks like ... is getting confused to be a relative path, while it was meant to be an ellipsis

[perrotta]

+1