Diamond Sampic reco

[ChrisMisan]

-----------------------------General overview----------------------------
Goal of this PR is to extend and modify existing sampic reco source(under RecoPPS/Local/) to provide support for the diamond detectors. Aside from providing additional functionality, the changes were structured in a way that avoid any code duplication and provides full backward compatibility. Users can choose between the two flows by using diamondSampicLocalReconstruction or totemTimingLocalReconstruction in a process path.

To test those changes, an additional producer named DiamondSampicDigiProducer was created. This producer takes testbeam data and converts them to totemTimingDigi (by utilising fake channel mapping), which could be then passed to the reco stage. PR contains an appropriate test file(RecoPPS/Local/test/totemTimingDigiConverter_reco_cfg) which produces reco by using this module as a starting point.

-----------------------------Implementation----------------------------
Changes to the existing file mainly concern source generalisation-to support both UFSD and DIAMOND Sampic flows. This is done either through class templates and then class specialization or extracting geometry information and applying conditional statements. Aside from those changes, some previously hardcoded parameters were extracted to python config and the obsolete code was removed.

For a more detailed overview, please refer to the provided pdf https://cernbox.cern.ch/index.php/s/2RQ0hD5B0QjLYYA

[cmsbuild]

@ChrisMisan, CMSSW_12_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34759/24424

• This PR adds an extra 72KB to repository

• Found files with invalid states:

  • RecoPPS/Local/python/totemTimingLocalReconstructionSampic_cff.py:
    • Added: 201c038
    • Deleted: 116f281

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

• RecoPPS/Local (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jan-kaspar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

@vavati @ebossiniCern @fabferro

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34759/24592

• This PR adds an extra 12KB to repository

• Found files with invalid states:

  • RecoPPS/Local/python/totemTimingLocalReconstructionSampic_cff.py:
    • Added: 201c038
    • Deleted: 116f281
  • RecoPPS/Local/plugins/DiamondSampicDigiProducer.cc:
    • Added: 116f281
    • Modified: bc290b0, 38e4eb2, d9294d6, 42cc452, d904033, 75367bf
    • Deleted: 465b165

[cmsbuild]

Pull request #34759 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[jpata]

@cmsbuild please test

[jpata]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2f6ce/17685/summary.html
COMMIT: 465b165
CMSSW: CMSSW_12_1_X_2021-08-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34759/17685/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 23434.2123434.21_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log
• 23434.9923434.99_TTbar_14TeV+2026D49PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D49PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log
• 23434.992123434.9921_TTbar_14TeV+2026D49PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log

Expand to see more relval errors ...

• 34834.21
• 34834.9921

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999420
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999391
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[ChrisMisan]

Sorry @jpata, what is the cause of error here?

[jpata]

@cmsbuild please test

it's not related to this PR, something seems wrong in the test infrastructure since some time. let's try again just in case.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2f6ce/17731/summary.html
COMMIT: 465b165
CMSSW: CMSSW_12_1_X_2021-08-12-0900/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34759/17731/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 45 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999420
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2999391
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• new functionality for PPS Diamond Sampic reconstruction (off by default)
• reco changes in totemTimingLocalTracks are expected: Diamond Sampic reco #34759 (comment), this does not affect downstream quantities

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1