Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on GEM onlineDQM due to the updates of DAQ dataformat, backport to CMSSW_11_3_X #34782

Merged

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Aug 4, 2021

PR description:

Since lots of stuffs in DAQ dataformat have been changed in #34504 (and #34585, the backport), the GEM onlineDQM has to be changed to adjust it. This PR is for it.

Also many of plots are rearranged, and new plots are added, which are plots of the average cluster sizes, etc..

This is the backport of #34614 to CMSSW_11_3_X.

PR validation:

Test are done and one can check again by runTheMatrix workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

To CMSSW_11_3_X to be deployed on current cosmic runs (i.e., CRUZET)

@jshlee @watson-ij @hyunyong

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

A new Pull Request was created by @quark2 for CMSSW_11_3_X.

It involves the following packages:

  • DQM/GEM (dqm)
  • DQM/Integration (dqm)
  • Validation/MuonGEMHits (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@jshlee, @threus, @batinkov, @watson-ij, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Aug 4, 2021

backport of #34614

@perrotta
Copy link
Contributor

perrotta commented Aug 4, 2021

please test with #34585

@perrotta
Copy link
Contributor

perrotta commented Aug 4, 2021

@quark2 @cms-sw/dqm-l2 please specify whether this is needed for the release to be run in the last days of cruzet

@quark2
Copy link
Contributor Author

quark2 commented Aug 4, 2021

Hi @perrotta,

as #34585, it is also needed for the release. This PR is for the update of online DQM equipping the modifications in #34585.

@perrotta
Copy link
Contributor

perrotta commented Aug 4, 2021

urgent

@cmsbuild cmsbuild added the urgent label Aug 4, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc09cd/17548/summary.html
COMMIT: b832683
CMSSW: CMSSW_11_3_X_2021-08-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34782/17548/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2874750
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2874709
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.473 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 0.016 KiB MuonGEMRecHitsV/GEMRecHitsTask
  • DQMHistoSizes: changed ( 10024.0,... ): 0.008 KiB MuonGEMHitsV/GEMHitsTask
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MuonGEMDigisV/GEMDigisTask
  • DQMHistoSizes: changed ( 11634.0,... ): 0.109 KiB GEM/Efficiency
  • DQMHistoSizes: changed ( 11634.0,... ): 0.047 KiB MuonGEMDigisV/GEMDigisTask
  • DQMHistoSizes: changed ( 11634.0,... ): 0.031 KiB MuonGEMRecHitsV/GEMRecHitsTask
  • DQMHistoSizes: changed ( 11634.0,... ): 0.016 KiB MuonGEMHitsV/GEMHitsTask
  • DQMHistoSizes: changed ( 23234.0,... ): 0.219 KiB GEM/Efficiency
  • DQMHistoSizes: changed ( 23234.0,... ): 0.094 KiB MuonGEMDigisV/GEMDigisTask
  • DQMHistoSizes: changed ( 23234.0,... ): 0.062 KiB MuonGEMRecHitsV/GEMRecHitsTask
  • DQMHistoSizes: changed ( 23234.0 ): ...
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

francescobrivio commented Aug 5, 2021

@jfernan2 can you have a look at this?
Tests are fine and you already signed the master PR.
it would be nice to include it in the new build for CRUZET! Thanks!

@ahmad3213
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

For completeness:
this PR was also tested live in the DQM playback system in P5 by the DQM team and no cashes were observed.

@perrotta
Copy link
Contributor

perrotta commented Aug 5, 2021

@quark2 out of curiosity, why did you split the plugins in DQM/GEM into a header and an implementation file? The suggestion is to move in the opposite direction (only one file in the \plugin area), and you were already there...

@perrotta
Copy link
Contributor

perrotta commented Aug 5, 2021

+1

  • Expected to be included in the release for the last days of Cruzet

@cmsbuild cmsbuild merged commit 559ddc2 into cms-sw:CMSSW_11_3_X Aug 5, 2021
@quark2
Copy link
Contributor Author

quark2 commented Aug 5, 2021

Hi @perrotta, I expected the module (or, especially, its inherited version) would be used in future, so I split them. But I'm not pretty sure if they will be used...

@perrotta
Copy link
Contributor

perrotta commented Aug 5, 2021

Hi @perrotta, I expected the module (or, especially, its inherited version) would be used in future, so I split them. But I'm not pretty sure if they will be used...

plugin modules should only act as plugins, remain local to the \plugin area, and they shouldn't be included from anywhere else.
My fault, I didn't notice it when I approved the PR in the master.

Not a big issue, anyhow: those plugin headers are never included from somewhere else. Anyhow, with no urgency, I'd suggest to revert the split in the master version of this PR, so that possible future developments will be based on it.

@quark2
Copy link
Contributor Author

quark2 commented Aug 5, 2021

@perrotta Okay, I'll merge them in the next updates. Thanks for your advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants