New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates on GEM onlineDQM due to the updates of DAQ dataformat, backport to CMSSW_11_3_X #34782
Updates on GEM onlineDQM due to the updates of DAQ dataformat, backport to CMSSW_11_3_X #34782
Conversation
A new Pull Request was created by @quark2 for CMSSW_11_3_X. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #34614 |
please test with #34585 |
@quark2 @cms-sw/dqm-l2 please specify whether this is needed for the release to be run in the last days of cruzet |
urgent |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc09cd/17548/summary.html Comparison SummarySummary:
|
@jfernan2 can you have a look at this? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
For completeness: |
@quark2 out of curiosity, why did you split the plugins in DQM/GEM into a header and an implementation file? The suggestion is to move in the opposite direction (only one file in the \plugin area), and you were already there... |
+1
|
Hi @perrotta, I expected the module (or, especially, its inherited version) would be used in future, so I split them. But I'm not pretty sure if they will be used... |
plugin modules should only act as plugins, remain local to the \plugin area, and they shouldn't be included from anywhere else. Not a big issue, anyhow: those plugin headers are never included from somewhere else. Anyhow, with no urgency, I'd suggest to revert the split in the master version of this PR, so that possible future developments will be based on it. |
@perrotta Okay, I'll merge them in the next updates. Thanks for your advice! |
PR description:
Since lots of stuffs in DAQ dataformat have been changed in #34504 (and #34585, the backport), the GEM onlineDQM has to be changed to adjust it. This PR is for it.
Also many of plots are rearranged, and new plots are added, which are plots of the average cluster sizes, etc..
This is the backport of #34614 to CMSSW_11_3_X.
PR validation:
Test are done and one can check again by
runTheMatrix
workflowsif this PR is a backport please specify the original PR and why you need to backport that PR:
To CMSSW_11_3_X to be deployed on current cosmic runs (i.e., CRUZET)
@jshlee @watson-ij @hyunyong