Remove dead code and apply one fix in DQM/L1TMonitor

[perrotta]

PR description:

The static analyzer is pointing to some unused code and dead initializations

While fixing them, I hit an obvious bug in previous L452 of DQM/L1TMonitor/src/L1TBPTX.cc where the numerator was filled twice, and none the numerator.

This makes me wonder whether this code was ever used... Anyhow, here is the fix.

PR validation:

It builds

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34794/24500

• This PR adds an extra 20KB to repository

[perrotta]

This is the bug that is fixed

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ba697/17569/summary.html
COMMIT: 0d8acbd
CMSSW: CMSSW_12_1_X_2021-08-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34794/17569/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999410
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999387
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[qliphy]

@cms-sw/dqm-l2 any comment?

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

Thank you @jfernan2 : did you get any idea about whether DQM/L1TMonitor/src/L1TBPTX.cc is ever used? Why the bug went unnoticed?

[jfernan2]

It seems to me it is used in:

cmssw/DQM/L1TMonitor/python/L1TMonitor_cff.py

Line 167 in 6d2f660

l1tBPTX +

for Online DQM but then removed in the clients.

cmssw/DQM/Integration/python/clients/l1t_dqm_sourceclient-live_cfg.py

Line 135 in 51c6c8e

process.l1tMonitorOnline.remove(process.l1tBPTX)

cmssw/DQM/Integration/python/clients/l1tstage1_dqm_sourceclient-live_cfg.py

Line 141 in 51c6c8e

process.l1tMonitorStage1Online.remove(process.l1tBPTX)

So, I am afraid it is only used in local tests. Hence, most likely not used any longer.

Let me include here L1T DQM contacts for confirmation:
@abrinke1 @apana @chadfreer @pgianneios @gkaratha @panoskatsoulis @benkrikler @aloeliger @vukasinmilosevic @dinyar @thomreis @rekovic @stahlleiton @hftsoi @mzarucki