Clean unused dependencies from BuildFiles

[guitargeek]

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #34544).

This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added for 12_1_0_pre1.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34809/24534

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4CMS/HGCalTestBeam/plugins/BuildFile.xml modified in PR(s): Phase2-TB63Z Rearrange the header file and make first example for dd4hep (replacing #34752) #34791

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

• Alignment/LaserAlignment (alca)
• CommonTools/CandAlgos (reconstruction)
• Configuration/Skimming (pdmv)
• DQM/GEM (dqm)
• IOMC/EventVertexGenerators (simulation)
• L1Trigger/L1TGEM (l1)
• PhysicsTools/HepMCCandAlgos (analysis)
• SimG4CMS/Calo (simulation)
• SimG4CMS/HGCalTestBeam (upgrade, simulation)
• SimG4CMS/HcalTestBeam (simulation)
• SimG4CMS/Muon (simulation)
• SimG4CMS/ShowerLibraryProducer (simulation)
• SimG4CMS/Tracker (simulation)
• SimG4Core/Application (simulation)
• SimGeneral/Debugging (simulation)

@andrius-k, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @AdrianoDee, @tlampen, @pohsun, @santocch, @cecilecaillol, @perrotta, @civanch, @yuanchao, @ErnestaP, @ahmad3213, @cmsbuild, @mdhildreth, @jfernan2, @kskovpen, @slava77, @jpata, @francescobrivio, @malbouis, @jordan-martins, @rekovic, @kmaeshima, @srimanob, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@adewit, @makortel, @cvuosalo, @jan-kaspar, @tocheng, @Martin-Grunewald, @bsunanda, @watson-ij, @thomreis, @felicepantaleo, @simonepigazzini, @mmusich, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffe4f9/17600/summary.html
COMMIT: a3765c0
CMSSW: CMSSW_12_1_X_2021-08-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34809/17600/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11606.011606.0_SingleMuPt1+2021+SingleMuPt1_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleMuPt1+2021+SingleMuPt1_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

• 11603.0
• 11604.0
• 11605.0
• 11607.0
• 11608.0
• 11609.0
• 11630.0
• 11634.0
• 11634.1
• 11634.24
• 11634.5
• 11634.501
• 11634.505
• 11634.511
• 11634.521
• 11650.0
• 11725.0
• 11634.7
• 11634.91
• 11640.0
• 11643.0
• 11646.0
• 11650.501
• 11650.505
• 11723.17
• 11834.13
• 11834.0
• 11834.24
• 11846.0
• 11925.0
• 12034.0
• 12434.0
• 12634.0
• 23434.9921
• 12834.0
• 13034.0
• 23434.99
• 23434.21
• 34834.21
• 34834.9921

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999410
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999381
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[srimanob]

@cmsbuild please test

Give it another try.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffe4f9/17615/summary.html
COMMIT: a3765c0
CMSSW: CMSSW_12_1_X_2021-08-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34809/17615/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999410
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999375
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

@bsunanda , do you agree with removal of these dependencies? I am sure they are not used now....

[slava77]

+reconstruction

for #34809 a3765c0

• code changes in reco are in CommonTools/CandAlgos/plugins/BuildFile.xml and appear to be correct
• jenkins tests pass

[civanch]

+1

[bbilin]

+1

[yuanchao]

+1

• clean unused depts. in buildfiles (technical)
• matrix tests and unit tests passed

[jfernan2]

+1

[srimanob]

+Upgrade

Technical PRs to clean unused dependencies.

[qliphy]

kindly ping @cms-sw/l1-l2

[qliphy]

+1

[qliphy]

merge

@cms-sw/l1-l2 Let's merge this technical PR first.

[santocch]

+1