Pixel cluster repair by morphing backport to 12_0_X

[czangela]

PR description:

Original PR description and validation at #34606.

PR validation:

Running the limited workflow w/ and w/o modifier: (as [done by @tsusa])(#34606 (comment))

runTheMatrix.py -l limited -i all —ibeos
runTheMatrix.py -l limited -i all —ibeos --command='--procModifiers=siPixelDigiMorphing'

w/ the modifier there were 12 failures: 37 33 25 19 14 4 1 1 1 tests passed, 2 3 7 0 0 0 0 0 0 failed;
From these 136.793 and 136.874 passed after running again, which leaves 10 failures:
136.88811, 140.53, 140.56, 11634.911, 11634.912, 23234.0, 28234.0, 34634.0, 34834.999, 250202.181
Missing configurations (no module named, product not found) were the problems with 140.53, 23234.0, 28234.0;
Overwritten modifiers/customizations (dd4hep, premix_stage1, premix_stage2, run2_miniAOD_UL_preSummer20) with 136.88811, 11634.911, 11634.912, , 34634.0, 34834.999, 250202.181;
140.56 is still being investigated.

Tests run with IB release CMSSW_12_0_X_2021-08-09-2300.

if this PR is a backport please specify the original PR and why you need to backport that PR:

#34606

[cmsbuild]

A new Pull Request was created by @czangela for CMSSW_12_0_X.

It involves the following packages:

• Configuration/ProcessModifiers (operations)
• RecoLocalTracker/Configuration (reconstruction)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoLocalTracker/SiPixelDigiReProducers (reconstruction)

@perrotta, @silviodonato, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @pieterdavid, @robervalwalsh, @Martin-Grunewald, @OzAmram, @threus, @makortel, @JanFSchulte, @ferencek, @yduhm, @GiacomoSguazzoni, @rovere, @VinInn, @alesaggio, @mmusich, @mtosi, @fabiocos, @gbenelli, @dkotlins, @gpetruc, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Pixel cluster repair by morphing #34606

[mmusich]

backport of #34606

[mmusich]

@cmsbuild, please test

[tvami]

@cmsbuild , please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d74fc/17732/summary.html
COMMIT: db8c328
CMSSW: CMSSW_12_0_X_2021-08-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34851/17732/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

• 11604.0
• 11605.0
• 11606.0
• 11607.0
• 11608.0
• 11609.0
• 11630.0
• 11634.0
• 11634.1
• 11634.24
• 11634.5
• 11634.501
• 11634.505
• 11634.511
• 11634.521
• 11634.7
• 11634.91
• 11640.0
• 11643.0
• 11646.0
• 11650.0
• 11650.501
• 11650.505
• 11723.17
• 11725.0
• 11834.0
• 11834.13
• 11834.24
• 11846.0
• 11925.0
• 12034.0
• 12434.0
• 12634.0
• 12834.0
• 13034.0
• 23434.21
• 23434.9921
• 23434.99
• 34834.21
• 34834.9921

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998529
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34851 db8c328

• code changes are the same as in Pixel cluster repair by morphing #34606 which was merged since CMSSW_12_1_X_2021-08-10-1100
  • as described in the original PR Pixel cluster repair by morphing #34606 this provides a feature needed for developments and private tests
  • IIUC, there may be small central production requests for detailed studies to justify the backport
• jenkins tests pass and comparisons with the baseline show no relevant differences

[perrotta]

+operations

• Backport is justified: even if not a bug fix for standard workflows to be run in 12_0_X, there can be production requests with the siPixelDigiMorphing modifier switched on

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge