Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT consumes for RECO and validation (not including performance changes) #3486

Merged
merged 7 commits into from Apr 29, 2014

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Apr 24, 2014

Consumes migration in DT reco and validation
partially replace #3450, rebased on top of CMSSW_7_1_X_2014-04-29-0200.
I've taken out all performance changes. These can be resubmitted separately.

@slava77 slava77 mentioned this pull request Apr 24, 2014
@slava77 slava77 changed the title DT consumes for HLT and validation DT consumes for RECO and validation with a fix for HLT Apr 24, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_1_X.

DT consumes for RECO and validation with a fix for HLT

It involves the following packages:

EventFilter/DTRawToDigi
EventFilter/DTTFRawToDigi
RecoLocalMuon/DTRecHit
RecoLocalMuon/DTSegment
Validation/DTRecHits

@thspeer, @danduggan, @rovere, @cmsbuild, @anton-a, @nclopezo, @deguio, @slava77, @Degano, @ojeda, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
I found an error when building:

>> Building edm plugin tmp/slc6_amd64_gcc481/src/Validation/EcalClusters/src/ValidationEcalClusters/libValidationEcalClusters.so
Leaving library rule at src/DQMServices/FwkIO/test
>> Building shared library tmp/slc6_amd64_gcc481/src/Validation/DTRecHits/src/ValidationDTRecHits/libValidationDTRecHits.so
>> Building edm plugin tmp/slc6_amd64_gcc481/src/Validation/GlobalHits/src/ValidationGlobalHits/libValidationGlobalHits.so
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lCalibCalorimetryEcalTPGTools
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc481/src/Validation/EcalDigis/src/ValidationEcalDigis/libValidationEcalDigis.so] Error 1
gmake: **\* Waiting for unfinished jobs....
Leaving library rule at src/DQMServices/FwkIO/plugins
Copying tmp/slc6_amd64_gcc481/src/Validation/DTRecHits/src/ValidationDTRecHits/libValidationDTRecHits.so to productstore area:
Leaving library rule at src/Validation/RecoHI/plugins


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3486/1026/summary.html

@slava77
Copy link
Contributor Author

slava77 commented Apr 25, 2014

jenkins should be rerun in CMSSW_7_1_X_2014-04-24-1400 or later, not in the broken IB

@davidlange6
Copy link
Contributor

ping @ktf, @nclopezo, @Degano, for rerunning tests - would be great to get this now old request integrated

@nclopezo
Copy link
Contributor

Hi David, I just queued again the tests for this pull request.

@slava77
Copy link
Contributor Author

slava77 commented Apr 28, 2014

I'm waiting for feedback on #3450 (which is the same code, just not rebased). The problem is that the changes introduce regressions which go in a direction of degrading performance.
I wish this PR was just the consumes fix.

@davidlange6
Copy link
Contributor

I see… naively the performance changes are in separate files than the consumes ones.. maybe its easy to separate them

On Apr 28, 2014, at 2:39 PM, Slava Krutelyov notifications@github.com
wrote:

I'm waiting for feedback on #3450 (which is the same code, just not rebased). The problem is that the changes introduce regressions which go in a direction of degrading performance.
I wish this PR was just the consumes fix.


Reply to this email directly or view it on GitHub.

@slava77
Copy link
Contributor Author

slava77 commented Apr 28, 2014

Looking at the commits, it appears to be factorizeable, if I take out 6d3131b, all that remains is consumes changes. I'll try this later today

@cmsbuild
Copy link
Contributor

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTRecHit/src/DTRecHitAlgoFactory.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTRecHit/src/DTRecHitBaseAlgo.cc 
Entering library rule at src/RecoLocalMuon/DTSegment/plugins
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTSegment/src/DTClusterer.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/EventFilter/DTTFRawToDigi/src/DTTFFEDReader.cc: In constructor 'DTTFFEDReader::DTTFFEDReader(const edm::ParameterSet&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/EventFilter/DTTFRawToDigi/src/DTTFFEDReader.cc:37:50: error: 'getDTTFInputTag' was not declared in this scope
   consumes(getDTTFInputTag());
                                                  ^
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTSegment/src/DTCombinatorialExtendedPatternReco.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTSegment/src/DTCombinatorialPatternReco.cc 
gmake: **\* [tmp/slc6_amd64_gcc481/src/EventFilter/DTTFRawToDigi/src/EventFilterDTTFRawToDigi/DTTFFEDReader.o] Error 1


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3486/1125/summary.html

@deguio
Copy link
Contributor

deguio commented Apr 29, 2014

+1
thanks @slava77 and @ptraczyk

@mulhearn
Copy link
Contributor

+1

@slava77
Copy link
Contributor Author

slava77 commented Apr 29, 2014

+1

for #3486 8a389a2

tested in CMSSW_7_1_X_2014-04-29-0200
(test area sign360 combined with pulls 3486 3530 3546 3548)
no regressions observed none expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 29, 2014
Reco -- DT consumes for RECO and validation (not including performance changes)
@ktf ktf merged commit 5a3ea09 into cms-sw:CMSSW_7_1_X Apr 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants