New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT consumes for RECO and validation (not including performance changes) #3486
Conversation
A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_1_X. DT consumes for RECO and validation with a fix for HLT It involves the following packages: EventFilter/DTRawToDigi @thspeer, @danduggan, @rovere, @cmsbuild, @anton-a, @nclopezo, @deguio, @slava77, @Degano, @ojeda, @mulhearn can you please review it and eventually sign? Thanks. |
-1 >> Building edm plugin tmp/slc6_amd64_gcc481/src/Validation/EcalClusters/src/ValidationEcalClusters/libValidationEcalClusters.so Leaving library rule at src/DQMServices/FwkIO/test >> Building shared library tmp/slc6_amd64_gcc481/src/Validation/DTRecHits/src/ValidationDTRecHits/libValidationDTRecHits.so >> Building edm plugin tmp/slc6_amd64_gcc481/src/Validation/GlobalHits/src/ValidationGlobalHits/libValidationGlobalHits.so /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lCalibCalorimetryEcalTPGTools collect2: error: ld returned 1 exit status gmake: **\* [tmp/slc6_amd64_gcc481/src/Validation/EcalDigis/src/ValidationEcalDigis/libValidationEcalDigis.so] Error 1 gmake: **\* Waiting for unfinished jobs.... Leaving library rule at src/DQMServices/FwkIO/plugins Copying tmp/slc6_amd64_gcc481/src/Validation/DTRecHits/src/ValidationDTRecHits/libValidationDTRecHits.so to productstore area: Leaving library rule at src/Validation/RecoHI/plugins you can see the results of the tests here: |
jenkins should be rerun in CMSSW_7_1_X_2014-04-24-1400 or later, not in the broken IB |
Hi David, I just queued again the tests for this pull request. |
I'm waiting for feedback on #3450 (which is the same code, just not rebased). The problem is that the changes introduce regressions which go in a direction of degrading performance. |
I see… naively the performance changes are in separate files than the consumes ones.. maybe its easy to separate them On Apr 28, 2014, at 2:39 PM, Slava Krutelyov notifications@github.com
|
Looking at the commits, it appears to be factorizeable, if I take out 6d3131b, all that remains is consumes changes. I'll try this later today |
-1 >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTRecHit/src/DTRecHitAlgoFactory.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTRecHit/src/DTRecHitBaseAlgo.cc Entering library rule at src/RecoLocalMuon/DTSegment/plugins >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTSegment/src/DTClusterer.cc /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/EventFilter/DTTFRawToDigi/src/DTTFFEDReader.cc: In constructor 'DTTFFEDReader::DTTFFEDReader(const edm::ParameterSet&)': /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/EventFilter/DTTFRawToDigi/src/DTTFFEDReader.cc:37:50: error: 'getDTTFInputTag' was not declared in this scope consumes(getDTTFInputTag()); ^ >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTSegment/src/DTCombinatorialExtendedPatternReco.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-28-0200/src/RecoLocalMuon/DTSegment/src/DTCombinatorialPatternReco.cc gmake: **\* [tmp/slc6_amd64_gcc481/src/EventFilter/DTTFRawToDigi/src/EventFilterDTTFRawToDigi/DTTFFEDReader.o] Error 1 you can see the results of the tests here: |
Take out changes affecting physics This reverts commit b0757c5.
+1 |
Reco -- DT consumes for RECO and validation (not including performance changes)
Consumes migration in DT reco and validation
partially replace #3450, rebased on top of CMSSW_7_1_X_2014-04-29-0200.
I've taken out all performance changes. These can be resubmitted separately.